From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pz0-f49.google.com ([209.85.210.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Rzxsp-0005G9-W4 for barebox@lists.infradead.org; Tue, 21 Feb 2012 22:08:28 +0000 Received: by dakp5 with SMTP id p5so8686442dak.36 for ; Tue, 21 Feb 2012 14:08:25 -0800 (PST) From: Marc Reilly Date: Wed, 22 Feb 2012 08:09:40 +1100 References: <1329784059-6006-1-git-send-email-eric@eukrea.com> <20120221153856.GL9343@game.jcrosoft.org> <20120221204501.GF3852@pengutronix.de> In-Reply-To: <20120221204501.GF3852@pengutronix.de> MIME-Version: 1.0 Message-Id: <201202220809.40257.marc@cpdesign.com.au> Reply-To: marc@cpdesign.com.au List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2142129937098016395==" Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 2/7] mfd: add mc34708 driver To: barebox@lists.infradead.org --===============2142129937098016395== Content-Type: multipart/alternative; boundary="Boundary-01=_UgARPTLzu5gxU/M" Content-Transfer-Encoding: 7bit --Boundary-01=_UgARPTLzu5gxU/M Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Hi, My $0.02 ... > > > for today we have what is inside barebox and this patche is coherent > > > with what is actually inside barebox (please check other drivers in mfd > > > and mx35-3stack for example). > > > For the future we may no more need this if we have a proper PMIC API > > > but as this API actually is not written, this patchset makes sense. > > > > today you do not need it > > > > today you just need to known it the chip is here > > > > so just check if the devfs is present > > Don't know where your problem is with exporting it. I also don't see the problem. 99.9% of designs using this IC (family) will only have one of them on a board. If someone puts more than one on their board then they should be the person to manage dealing with two. > Yes, it supports > only a single pmic, but that's all we have on the boards I know. And > this function can be used to modify registers on the pmic, some boards > need this. The day might come when we need some regulator API, but we > are not there and The board I have uses an mc13892 - there is stuff we need to we need to do which is unrelated to regulators like increasing the charge/supply current and detecting critically low battery. Calling xxxx_set_bits() is much better than a read/modify/write from dev file. > often enough getting a board to run properly is just > 'modify this damn bit in the pmic' I've said "this damn pmic" quite a few times about the 13892 :) (Has anyone else had troubles too?) Cheers, Marc --Boundary-01=_UgARPTLzu5gxU/M Content-Type: text/html; charset="iso-8859-15" Content-Transfer-Encoding: 7bit

Hi,


My $0.02 ...



> > > for today we have what is inside barebox and this patche is coherent

> > > with what is actually inside barebox (please check other drivers in mfd

> > > and mx35-3stack for example).

> > > For the future we may no more need this if we have a proper PMIC API

> > > but as this API actually is not written, this patchset makes sense.

> >

> > today you do not need it

> >

> > today you just need to known it the chip is here

> >

> > so just check if the devfs is present

>

> Don't know where your problem is with exporting it.


I also don't see the problem. 99.9% of designs using this IC (family) will only have one of them on a board. If someone puts more than one on their board then they should be the person to manage dealing with two.


> Yes, it supports

> only a single pmic, but that's all we have on the boards I know. And

> this function can be used to modify registers on the pmic, some boards

> need this. The day might come when we need some regulator API, but we

> are not there and


The board I have uses an mc13892 - there is stuff we need to we need to do which is unrelated to regulators like increasing the charge/supply current and detecting critically low battery. Calling xxxx_set_bits() is much better than a read/modify/write from dev file.



> often enough getting a board to run properly is just

> 'modify this damn bit in the pmic'


I've said "this damn pmic" quite a few times about the 13892 :) (Has anyone else had troubles too?)



Cheers,

Marc

--Boundary-01=_UgARPTLzu5gxU/M-- --===============2142129937098016395== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox --===============2142129937098016395==--