mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC V2 0/6] barebox PCI support
Date: Fri, 9 Mar 2012 18:56:50 +0100	[thread overview]
Message-ID: <20120309175650.GJ3852@pengutronix.de> (raw)
In-Reply-To: <1331236232-32735-1-git-send-email-antonynpavlov@gmail.com>

Hi Antony,

On Thu, Mar 08, 2012 at 11:50:26PM +0400, Antony Pavlov wrote:
> This patch series introduce PCI support to barebox.
> 
> Thanks to Jean-Christophe PLAGNIOL-VILLARD for reviewing and adding
> some PCI common code.
> 
> The patches are draft. They need a very big future work, so I put on them "RFC"
> title instead of "PATCH".

Overall this looks quite nice now. I think we are getting in the region
of 'merging in the near future'. There are some fixme markers aka C++
comments which should simply be removed like non present irq includes.
With others I don't understand if they have something to do with your
hardware or with porting PCI in general to barebox. I don't know much
about PCI, so only some comments inline where better barebox integration
is needed.

Thanks for working on this.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2012-03-09 17:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 19:50 Antony Pavlov
2012-03-08 19:50 ` [RFC V2 1/6] PCI: initial commit (draft) Antony Pavlov
2012-03-09 18:01   ` Sascha Hauer
2012-03-08 19:50 ` [RFC V2 2/6] MIPS: add file gt64120.h from linux 2.6.39 Antony Pavlov
2012-03-08 19:50 ` [RFC V2 3/6] MIPS: add PCI support for GT64120-based malta Antony Pavlov
2012-03-08 19:50 ` [RFC V2 4/6] PCI: add draft lspci command Antony Pavlov
2012-03-08 19:50 ` [RFC V2 5/6] net: add Realtek 8139 Ethernet controller support Antony Pavlov
2012-03-09 18:17   ` Sascha Hauer
2012-03-08 19:50 ` [RFC V2 6/6] net: add DEC 21143 (tulip) " Antony Pavlov
2012-03-09 17:56 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120309175650.GJ3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox