From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1S7Qlw-0003lE-DG for barebox@lists.infradead.org; Tue, 13 Mar 2012 12:24:13 +0000 Date: Tue, 13 Mar 2012 13:24:06 +0100 From: Sascha Hauer Message-ID: <20120313122406.GW3852@pengutronix.de> References: <201203121457.59975.jbe@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201203121457.59975.jbe@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: serial S3: fix local structure malloc To: Juergen Beisert Cc: barebox@lists.infradead.org On Mon, Mar 12, 2012 at 02:57:59PM +0100, Juergen Beisert wrote: > Patch 2c5404651091e985c9009aa417d80fdaf50d7a68 introduces a private structure > for the S3C based UARTs but still reserves the memory for the smaller > structure which fails at runtime. > > Signed-off-by: Juergen Beisert Applied to master, thanks Sascha > > diff --git a/drivers/serial/serial_s3c.c b/drivers/serial/serial_s3c.c > index a5fd4ee..2bdc1df 100644 > --- a/drivers/serial/serial_s3c.c > +++ b/drivers/serial/serial_s3c.c > @@ -153,7 +153,7 @@ static int s3c_serial_probe(struct device_d *dev) > struct s3c_uart *priv; > struct console_device *cdev; > > - priv = xzalloc(sizeof(struct console_device)); > + priv = xzalloc(sizeof(struct s3c_uart)); > cdev = &priv->cdev; > priv->regs = dev_request_mem_region(dev, 0); > dev->priv = priv; > > -- > Pengutronix e.K. | Juergen Beisert | > Linux Solutions for Science and Industry | Phone: +49-5121-206917-5128 | > Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ | > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox