From: Sascha Hauer <s.hauer@pengutronix.de>
To: guenter.gebhardt@rafi.de
Cc: barebox@lists.infradead.org
Subject: Re: barebox-2012.03.0 imx_get_i2cclk
Date: Thu, 22 Mar 2012 10:26:44 +0100 [thread overview]
Message-ID: <20120322092644.GZ3852@pengutronix.de> (raw)
In-Reply-To: <OF238DCFD4.07670D15-ONC12579C8.0049BABE-C12579C8.004A1884@o0802.rafi.inhouse>
On Wed, Mar 21, 2012 at 02:29:18PM +0100, guenter.gebhardt@rafi.de wrote:
> Hello,
>
> when compiling for a imx53 with i2c enabled i got the following error:
>
> drivers/built-in.o: In function `i2c_imx_set_clk':
> /home/ggebhardt/repos/ecuv6_bl/barebox/drivers/i2c/busses/i2c-imx.c:282:
> undefined reference to `imx_get_i2cclk'
> make[4]: *** [.tmp_barebox1] Error 1
> make[3]: *** [CMakeFiles/bootloader] Error 2
> make[2]: *** [CMakeFiles/bootloader.dir/all] Error 2
> make[1]: *** [CMakeFiles/bootloader.dir/rule] Error 2
> make: *** [bootloader] Error 2
>
> I copied the following from the corresponding imx51 implementation:
>
> diff --git a/barebox/arch/arm/mach-imx/speed-imx53.c
> b/barebox/arch/arm/mach-imx/speed-imx53.c
> index 0d6ac24..a168c65 100644
> --- a/barebox/arch/arm/mach-imx/speed-imx53.c
> +++ b/barebox/arch/arm/mach-imx/speed-imx53.c
> @@ -169,6 +169,11 @@ unsigned long imx_get_fecclk(void)
> return imx_get_ipgclk();
> }
>
> +unsigned long imx_get_i2cclk(void)
> +{
> + return imx_get_ipgclk();
> +}
The patch looks good. Could you create a formal patch with a proper
subject and signed-off-by?
Sascha
> +
> unsigned long imx_get_mmcclk(void)
> {
> u32 reg, prediv, podf, rate;
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-03-22 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 13:29 guenter.gebhardt
2012-03-22 9:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322092644.GZ3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=guenter.gebhardt@rafi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox