mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: esben.haabendal@gmail.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/4] mxs: iomux configuration improvements
Date: Mon, 2 Apr 2012 10:12:28 +0200	[thread overview]
Message-ID: <20120402081228.GH3852@pengutronix.de> (raw)
In-Reply-To: <1332782947-3407-1-git-send-email-esben.haabendal@gmail.com>

On Mon, Mar 26, 2012 at 07:29:03PM +0200, esben.haabendal@gmail.com wrote:
> From: Esben Haabendal <esben.haabendal@gmail.com>
> 
> These patches completes the iomux configuration definitions in
> iomux-imx28.h, fixes a bug for PWM3 pad configuration, and fixes
> support for using BITKEEPER(1) in pad configurations.
> 
> RFC: It might be better to just get rid of the split between BITKEEPER
> and PULLUP in definitions.  It clearly is a source for subtle bugs
> (setting PULLUP does not really do anything if the pad/function is
> actually defined as a keeper pad.  As for i.MX28 the reference manual
> is not very clear on which pads/functions have pullup instead of
> keeper, and I am not sure that the current defintions in barebox is in
> sync with the manual and/or the real world.  What do you think, should
> I make a patch unifying PULLUP and BITKEEPER.
> 
> Esben Haabendal (4):
>   mxs: Fix support for BITKEEPER() macro
>   mxs: Fix i.MX28 PWM3 iomux configuration
>   mxs: Cleanup use of blank lines in i.MX28 iomux configurations
>   mxs: Add remaining i.MX28 iomux configurations

Applied, thanks.

Sascha

> 
>  arch/arm/mach-mxs/include/mach/iomux-imx28.h |  163 +++++++++++++++++++-------
>  arch/arm/mach-mxs/iomux-imx.c                |    6 +
>  2 files changed, 126 insertions(+), 43 deletions(-)
> 
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2012-04-02  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 17:29 esben.haabendal
2012-03-26 17:29 ` [PATCH 1/4] mxs: Fix support for BITKEEPER() macro esben.haabendal
2012-04-02  8:44   ` Sascha Hauer
2012-03-26 17:29 ` [PATCH 2/4] mxs: Fix i.MX28 PWM3 iomux configuration esben.haabendal
2012-03-26 17:29 ` [PATCH 3/4] mxs: Cleanup use of blank lines in i.MX28 iomux configurations esben.haabendal
2012-03-26 17:29 ` [PATCH 4/4] mxs: Add remaining " esben.haabendal
2012-04-02  8:12 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120402081228.GH3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=esben.haabendal@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox