From: Sascha Hauer <s.hauer@pengutronix.de>
To: esben.haabendal@gmail.com
Cc: barebox@lists.infradead.org, Esben Haabendal <esben.haabendal@prevas.dk>
Subject: Re: [PATCH 1/4] mxs: Fix support for BITKEEPER() macro
Date: Mon, 2 Apr 2012 10:44:53 +0200 [thread overview]
Message-ID: <20120402084453.GV26642@pengutronix.de> (raw)
In-Reply-To: <1332782947-3407-2-git-send-email-esben.haabendal@gmail.com>
Hi Esben,
On Mon, Mar 26, 2012 at 07:29:04PM +0200, esben.haabendal@gmail.com wrote:
> From: Esben Haabendal <esben.haabendal@gmail.com>
>
> There was no check for BE, so any BITKEEPER(1) iomux configurations
> were not being applied.
>
> Signed-off-by: Esben Haabendal <esben.haabendal@prevas.dk>
> ---
> arch/arm/mach-mxs/iomux-imx.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/iomux-imx.c b/arch/arm/mach-mxs/iomux-imx.c
> index 3161a5d..6bcde03 100644
> --- a/arch/arm/mach-mxs/iomux-imx.c
> +++ b/arch/arm/mach-mxs/iomux-imx.c
> @@ -128,6 +128,12 @@ void imx_gpio_mode(uint32_t m)
> (GET_PULLUP(m) == 1 ? BIT_SET : BIT_CLR));
> }
>
> + if (BK_PRESENT(m)) {
> + reg_offset = calc_pullup_reg(gpio_pin);
> + writel(0x1 << (gpio_pin % 32), IMX_IOMUXC_BASE + reg_offset +
> + (GET_BITKEEPER(m) == 1 ? BIT_SET : BIT_CLR));
> + }
I just noticed this breaks i.MX23 support:
arch/arm/mach-mxs/iomux-imx.c: In function 'imx_gpio_mode':
arch/arm/mach-mxs/iomux-imx.c:131:2: warning: implicit declaration of function 'BK_PRESENT' [-Wimplicit-function-declaration]
arch/arm/mach-mxs/iomux-imx.c:133:3: warning: implicit declaration of function 'GET_BITKEEPER' [-Wimplicit-function-declaration]
arch/arm/mach-mxs/built-in.o: In function `imx_gpio_mode':
/home/sha/dude/barebox/barebox/arch/arm/mach-mxs/iomux-imx.c:131: undefined reference to `BK_PRESENT'
/home/sha/dude/barebox/barebox/arch/arm/mach-mxs/iomux-imx.c:133: undefined reference to `GET_BITKEEPER'
make: *** [barebox] Error 1
Care to send a fix for this? You can reproduce this using the
chumby_defconfig.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-04-02 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 17:29 [PATCH 0/4] mxs: iomux configuration improvements esben.haabendal
2012-03-26 17:29 ` [PATCH 1/4] mxs: Fix support for BITKEEPER() macro esben.haabendal
2012-04-02 8:44 ` Sascha Hauer [this message]
2012-03-26 17:29 ` [PATCH 2/4] mxs: Fix i.MX28 PWM3 iomux configuration esben.haabendal
2012-03-26 17:29 ` [PATCH 3/4] mxs: Cleanup use of blank lines in i.MX28 iomux configurations esben.haabendal
2012-03-26 17:29 ` [PATCH 4/4] mxs: Add remaining " esben.haabendal
2012-04-02 8:12 ` [PATCH 0/4] mxs: iomux configuration improvements Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402084453.GV26642@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=esben.haabendal@gmail.com \
--cc=esben.haabendal@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox