From: Sascha Hauer <s.hauer@pengutronix.de>
To: Anand Gadiyar <gadiyar@gmail.com>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: OMAP4 Panda - MMC access broken
Date: Tue, 10 Apr 2012 11:23:36 +0200 [thread overview]
Message-ID: <20120410092336.GD3852@pengutronix.de> (raw)
In-Reply-To: <CAO-mwNdKa4fukB23m_F1g=axhqw3S2stb2C6JbPXiob1Ty=xhg@mail.gmail.com>
On Mon, Apr 02, 2012 at 08:07:16PM +0530, Anand Gadiyar wrote:
> On Fri, Mar 30, 2012 at 10:04 PM, Anand Gadiyar <gadiyar@gmail.com> wrote:
>
> > Hi all,
> >
> > I've just started playing with barebox on OMAP4. I see that with "Release
> > v2011.11.0", my Panda could access the SD card contents, but with the
> > current release it can no longer do so.
> >
> > Git bisect shows commit 82db23d3f4c1de25bbd4b222a3bd9e81d00414f8 (Use
> > generic block layer to access the drives and do partition parsing) is when
> > it stopped working.
> >
> > Any pointers?
> >
> > Thanks in advance,
> > Anand
> >
> >
> Found the problem. I was using a 4GB SD card with just a single FAT32
> partition. The pentry.size is reported as 7744449 which fails the
> check_offset_value() call.
> I think this is the same issue Sanjeev reported in February.
>
> Below patch seems to fix the issue for now. But I'm not sure what's the
> correct way to fix this.
The correct way would be to make all this stuff 64bit types. I am
working for this for quite some time and have a series for an older
barebox doing this. I would have to rebase it.
Sascha
>
> Index: barebox/common/partitions.c
> ===================================================================
> --- barebox.orig/common/partitions.c
> +++ barebox/common/partitions.c
> @@ -129,8 +129,6 @@ static void __maybe_unused try_dos_parti
> /* do we have to ignore this partition due to limitations?
> */
> if (check_offset_value(pentry.first_sec) != 0)
> continue;
> - if (check_offset_value(pentry.size) != 0)
> - continue;
>
> if (pentry.first_sec != 0) {
> pd->parts[pd->used_entries].first_sec =
> pentry.first_sec;
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-04-10 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 16:34 Anand Gadiyar
2012-04-02 14:37 ` Anand Gadiyar
2012-04-10 9:23 ` Sascha Hauer [this message]
2012-04-10 11:51 ` Anand Gadiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410092336.GD3852@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=gadiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox