From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH 1/1] arm: add Android boot image support
Date: Thu, 12 Apr 2012 13:29:35 +0200 [thread overview]
Message-ID: <20120412112935.GB11079@game.jcrosoft.org> (raw)
In-Reply-To: <20120412100109.GV3852@pengutronix.de>
On 12:01 Thu 12 Apr , Sascha Hauer wrote:
> On Wed, Apr 11, 2012 at 07:42:34AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > The Android Image contains 3 components and params
> >
> > - kernel
> > - initrd
> > - second stage (optional)
> >
> > - tags addr
> > - bootargs
> >
> > In fast boot the initrd is mandatory, in barebox we are less restrictive
> > use the initrd only if present
> >
> > add to env params:
> > image_noverwrite_bootargs
> > Disable overwrite of the bootargs with the one present in aimage
> >
> > aimage_noverwrite_tags
> > Disable overwrite of the tags addr with the one present in aimage
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > ---
> > arch/arm/lib/bootm.c | 147 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > commands/Kconfig | 7 +++
> > include/aimage.h | 74 +++++++++++++++++++++++++
> > 3 files changed, 228 insertions(+), 0 deletions(-)
> > create mode 100644 include/aimage.h
> >
> > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
>
> Can we have this in a seperate file? You made Android support optional
> already and support is only registered when the option is enabled, but
> the code is compiled even without the option.
IIRC the struct is droped by the garbage collector as it's never used
the idea is to compile it always but drop it is not used
without the option
# ls -al build/tny-a9263/barebox.bin
-rwxr-xr-x 1 root root 259056 Apr 12 18:29 build/tny-a9263/barebox.bin
with it
# ls -al build/tny-a9263/barebox.bin
-rwxr-xr-x 1 root root 259960 Apr 12 19:45 build/tny-a9263/barebox.bin
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-04-12 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 5:42 Jean-Christophe PLAGNIOL-VILLARD
2012-04-11 6:13 ` Baruch Siach
2012-04-11 7:25 ` [PATCH 1/1] filetype: " Jean-Christophe PLAGNIOL-VILLARD
2012-04-12 10:01 ` Sascha Hauer
2012-04-12 10:01 ` [PATCH 1/1] arm: " Sascha Hauer
2012-04-12 11:29 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412112935.GB11079@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox