From: "Eric Bénard" <eric@eukrea.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] i.MX53: Move specific i.MX53 silicon definitions to imx53-regs.h
Date: Thu, 12 Apr 2012 21:04:15 +0200 [thread overview]
Message-ID: <20120412210415.3a0313e2@eb-e6520> (raw)
In-Reply-To: <1334247624-24896-2-git-send-email-shc_work@mail.ru>
Le Thu, 12 Apr 2012 20:20:19 +0400,
Alexander Shiyan <shc_work@mail.ru> a écrit :
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/mach-imx/imx53.c | 6 +++---
> arch/arm/mach-imx/include/mach/imx-regs.h | 5 -----
> arch/arm/mach-imx/include/mach/imx53-regs.h | 5 +++++
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx53.c b/arch/arm/mach-imx/imx53.c
> index 8742c46..951e4c6 100644
> --- a/arch/arm/mach-imx/imx53.c
> +++ b/arch/arm/mach-imx/imx53.c
> @@ -55,15 +55,15 @@ static int query_silicon_revision(void)
> rev = readl(rom + SI_REV);
> switch (rev) {
> case 0x10:
> - mx53_silicon_revision = IMX_CHIP_REV_1_0;
> + mx53_silicon_revision = MX53_CHIP_REV_1_0;
> mx53_rev_string = "1.0";
> break;
> case 0x20:
> - mx53_silicon_revision = IMX_CHIP_REV_2_0;
> + mx53_silicon_revision = MX53_CHIP_REV_2_0;
> mx53_rev_string = "2.0";
> break;
> case 0x21:
> - mx53_silicon_revision = IMX_CHIP_REV_2_1;
> + mx53_silicon_revision = MX53_CHIP_REV_2_1;
> mx53_rev_string = "2.1";
> break;
> default:
> diff --git a/arch/arm/mach-imx/include/mach/imx-regs.h b/arch/arm/mach-imx/include/mach/imx-regs.h
> index 789397e..a272dda 100644
> --- a/arch/arm/mach-imx/include/mach/imx-regs.h
> +++ b/arch/arm/mach-imx/include/mach/imx-regs.h
> @@ -105,9 +105,4 @@
>
> #define GPIO_GIUS (1<<16)
>
> -/* silicon revisions */
> -#define IMX_CHIP_REV_1_0 0x10
> -#define IMX_CHIP_REV_2_0 0x20
> -#define IMX_CHIP_REV_2_1 0x21
> -
> #endif /* _IMX_REGS_H */
> diff --git a/arch/arm/mach-imx/include/mach/imx53-regs.h b/arch/arm/mach-imx/include/mach/imx53-regs.h
> index 8fefc54..065bf08 100644
> --- a/arch/arm/mach-imx/include/mach/imx53-regs.h
> +++ b/arch/arm/mach-imx/include/mach/imx53-regs.h
> @@ -135,5 +135,10 @@
> #define MX53_CS2_96MB_BASE_ADDR 0xF6000000
> #define MX53_CS3_BASE_ADDR 0xF6000000
>
> +/* silicon revisions specific to i.MX53 */
> +#define MX53_CHIP_REV_1_0 0x10
> +#define MX53_CHIP_REV_2_0 0x20
> +#define MX53_CHIP_REV_2_1 0x21
> +
> #endif /* __MACH_IMX53_REGS_H */
>
The goal was to move chip revision to imx-regs.h and remove them from
other files (as MX25/35/51/53 seems to share the same pattern for chip
revision)
Eric
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-04-12 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 16:20 [PATCH 1/7] i.MX51: Allow to pass cpu clock to lowlevel init Alexander Shiyan
2012-04-12 16:20 ` [PATCH 2/7] i.MX53: Move specific i.MX53 silicon definitions to imx53-regs.h Alexander Shiyan
2012-04-12 19:04 ` Eric Bénard [this message]
2012-04-12 19:47 ` Sascha Hauer
2012-04-12 19:49 ` Re[2]: " Alexander Shiyan
2012-04-12 16:20 ` [PATCH 3/7] i.MX51: Add iomux definitions for SDHC3 Alexander Shiyan
2012-04-12 20:11 ` Sascha Hauer
2012-04-12 16:20 ` [PATCH 4/7] i.MX51: Add iomux definitions for GPIO3.0 Alexander Shiyan
2012-04-12 16:20 ` [PATCH 5/7] i.MX51: Add iomux definitions for I2C2 Alexander Shiyan
2012-04-12 16:20 ` [PATCH 6/7] i.MX51: Add PAD_CTL_HYS bit to SD_CLK pads Alexander Shiyan
2012-04-12 19:05 ` Eric Bénard
2012-04-12 19:44 ` Re[2]: " Alexander Shiyan
2012-04-12 16:20 ` [PATCH 7/7] i.MX51: Add support for SDHC3 Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412210415.3a0313e2@eb-e6520 \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox