mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 09/11] complete: add go and sleep support
Date: Mon, 23 Apr 2012 08:03:27 +0200	[thread overview]
Message-ID: <20120423060327.GU3852@pengutronix.de> (raw)
In-Reply-To: <1334814298-11468-9-git-send-email-plagnioj@jcrosoft.com>

On Thu, Apr 19, 2012 at 07:44:56AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  commands/go.c      |    2 ++
>  commands/sleep.c   |    2 ++
>  common/complete.c  |    5 +++++
>  include/complete.h |    1 +
>  4 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/commands/go.c b/commands/go.c
> index c821207..e9e9d40 100644
> --- a/commands/go.c
> +++ b/commands/go.c
> @@ -25,6 +25,7 @@
>  
>  #include <common.h>
>  #include <command.h>
> +#include <complete.h>
>  #include <fs.h>
>  #include <fcntl.h>
>  #include <linux/ctype.h>
> @@ -91,4 +92,5 @@ BAREBOX_CMD_START(go)
>  	.cmd		= do_go,
>  	.usage		= "start application at address or file",
>  	BAREBOX_CMD_HELP(cmd_go_help)
> +	BAREBOX_CMD_COMPLETE(cammand_var_complete)
>  BAREBOX_CMD_END
> diff --git a/commands/sleep.c b/commands/sleep.c
> index f772e87..c5f7867 100644
> --- a/commands/sleep.c
> +++ b/commands/sleep.c
> @@ -22,6 +22,7 @@
>  
>  #include <common.h>
>  #include <command.h>
> +#include <complete.h>
>  #include <clock.h>
>  
>  static int do_sleep(int argc, char *argv[])
> @@ -46,4 +47,5 @@ static int do_sleep(int argc, char *argv[])
>  BAREBOX_CMD_START(sleep)
>  	.cmd		= do_sleep,
>  	.usage		= "delay execution for n seconds",
> +	BAREBOX_CMD_COMPLETE(cammand_var_complete)
>  BAREBOX_CMD_END
> diff --git a/common/complete.c b/common/complete.c
> index 5213b10..9ecce25 100644
> --- a/common/complete.c
> +++ b/common/complete.c
> @@ -193,6 +193,11 @@ int empty_complete(struct string_list *sl, char *instr)
>  	return 1;
>  }
>  
> +int cammand_var_complete(struct string_list *sl, char *instr)
> +{
> +	return 0;
> +}

Two patches before this one you introduced empty_complete. This function
does the same, except that it returns 0 instead of 1. The return value
of the complete functions is never checked, so what is going on here?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-04-23  6:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19  5:38 [PATCH 00/11 v2] improve complete support Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 01/11] stringlist: use seperately allocated string Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 02/11] stringlist: implement string_list_add_asprintf Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 03/11] complete: add var and device param complete support Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 04/11] complete: add generic command complete framework Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 05/11] complete: add device name complete support for devinfo Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 06/11] complete: add help complete support Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 07/11] complete: add empty " Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 08/11] complete: add eth interface " Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 09/11] complete: add go and sleep support Jean-Christophe PLAGNIOL-VILLARD
2012-04-23  6:03   ` Sascha Hauer [this message]
2012-04-23  6:21     ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-23  7:07       ` Sascha Hauer
2012-04-23  7:01         ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-23 13:34           ` Sascha Hauer
2012-04-19  5:44 ` [PATCH 10/11] complete: add delpart complete support Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  5:44 ` [PATCH 11/11] complete: add executable file support Jean-Christophe PLAGNIOL-VILLARD
2012-04-19  6:39 ` [PATCH 00/11 v2] improve complete support Sascha Hauer
2012-04-19 11:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-30 12:23 [PATCH 00/11 v3] " Jean-Christophe PLAGNIOL-VILLARD
2012-04-30 12:26 ` [PATCH 09/11] complete: add go and sleep support Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423060327.GU3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox