mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH V3 1/3] Preparation stage to support multiple PPC architectures
Date: Mon, 23 Apr 2012 09:15:47 +0200	[thread overview]
Message-ID: <20120423071547.GC3852@pengutronix.de> (raw)
In-Reply-To: <1334913691-13315-2-git-send-email-renaud.barbier@ge.com>

On Fri, Apr 20, 2012 at 10:21:29AM +0100, Renaud Barbier wrote:
> arch/ppc/Kconfig is reworked to make the configuration environment
> architecture neutral. All MPC5200 configuration is moved to the
> MPC5200 architecture specific configuration file. These modifications
> are reflected in the PCM030 board support.
> 
> arch/ppc/Makefile compilation directives are updated in preparation
> for the introduction of future cpus/machines.
> 
> lib/time.c is moved to an architecture specific version and the
> building instructions updated in the Makefile. The file
> now named time-mpc5200.c is cleaned up of unused code.
> 
> The definition of L1_CACHE_... is updated and CACHELINE_SIZE is
> defined in ppc/include/asm/cache.h for future use by the mpc85xx.
> The file mach-mpc5xxx/pci_mpc5200.c and mach-mpc5xxx/start.S are
> updated accordingly.
> 
> The declaration of search_exception_table is moved in
> include/asm/common.h because it is used across architectures.
> mach-mpc5xxx/traps.c is also updated to reflect this change.
> 
> Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
> ---
>  arch/ppc/Kconfig                        |   42 +++---------------------------
>  arch/ppc/Makefile                       |   19 ++++++++-----
>  arch/ppc/configs/pcm030_defconfig       |    3 ++
>  arch/ppc/include/asm/cache.h            |   17 +++++-------
>  arch/ppc/include/asm/common.h           |    1 +
>  arch/ppc/lib/Makefile                   |    2 +-
>  arch/ppc/lib/{time.c => time-mpc5200.c} |   27 ++-----------------

Since this function will be mpc5xxx only can you move it to
mach-mpc5xxx/time.c please?

Otherwise this patch looks fine, I'll apply it once this one is fixed.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-04-23  7:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 13:04 [PATCH V2 0/3] MPC85xx support Renaud Barbier
2012-04-13 13:04 ` [PATCH V2 1/3] Preparation stage to support multiple PPC architectures Renaud Barbier
2012-04-13 13:04 ` [PATCH V2 2/3] Minimal support of the MPC85xx architecture Renaud Barbier
2012-04-13 13:04 ` [PATCH V2 3/3] Minimal P2020RDB platform support and configuration file Renaud Barbier
2012-04-15 14:59 ` [PATCH V2 0/3] MPC85xx support Sascha Hauer
2012-04-20  9:21   ` [PATCH V3 " Renaud Barbier
2012-04-20  9:21   ` [PATCH V3 1/3] Preparation stage to support multiple PPC architectures Renaud Barbier
2012-04-23  7:15     ` Sascha Hauer [this message]
2012-04-20  9:21   ` [PATCH V3 2/3] Minimal support of the MPC85xx architecture Renaud Barbier
2012-04-23  8:13     ` Sascha Hauer
2012-04-20  9:21   ` [PATCH V3 3/3] Minimal P2020RDB platform support and configuration file Renaud Barbier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423071547.GC3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=renaud.barbier@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox