From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Disallow to selecting MCI_IMX_ESDHC for i.MX27 & i.MX31 targets
Date: Fri, 27 Apr 2012 09:42:34 +0200 [thread overview]
Message-ID: <20120427074234.GT17184@pengutronix.de> (raw)
In-Reply-To: <1335459724-25546-1-git-send-email-shc_work@mail.ru>
On Thu, Apr 26, 2012 at 09:02:03PM +0400, Alexander Shiyan wrote:
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/mci/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mci/Kconfig b/drivers/mci/Kconfig
> index b1a678e..6bae586 100644
> --- a/drivers/mci/Kconfig
> +++ b/drivers/mci/Kconfig
> @@ -54,7 +54,7 @@ config MCI_IMX
>
> config MCI_IMX_ESDHC
> bool "i.MX esdhc"
> - depends on ARCH_IMX
> + depends on ARCH_IMX && !ARCH_IMX27 && !ARCH_IMX31
No, please don't. Apart from the fact that mx1 and mx21 are missing
above it's not worth it. All that can happen is that you can enable
support for a device which is not present on your system. Apart from
needed binary space there's nothing wrong with that.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-04-27 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 17:02 Alexander Shiyan
2012-04-26 17:02 ` [PATCH 2/2] PCM038: choose boot device by parsing barebox_loc magic variable Alexander Shiyan
2012-04-27 7:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120427074234.GT17184@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox