Re: [PATCH 3/4] Minimal S5PV210 + Tiny210 support (2nd stage only)

[Juergen Beisert <jbe@pengutronix.de>]

Alexey Galakhov wrote:
> [...]
> diff --git a/arch/arm/boards/tiny210/lowlevel.c b/arch/arm/boards/tiny210/lowlevel.c
> new file mode 100644 
> index 0000000..3615d8a
> --- /dev/null
> +++ b/arch/arm/boards/tiny210/lowlevel.c
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (C) 2012 Alexey Galakhov
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +#include <config.h>
> +#include <common.h>
> +#include <init.h>
> +#include <io.h>
> +#include <asm/barebox-arm.h>
> +#include <mach/s3c-iomap.h>
> +#include <mach/s3c-clocks.h>
> +
> +void __bare_init board_init_lowlevel(void)
> +{
> +}

Why do you add an empty function?

[...]

Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox