[PATCH] PCM038: Removed unnecessary call to gpio_set_value

[PATCH] PCM038: Removed unnecessary call to gpio_set_value

[Alexander Shiyan]

The value already is set by calling gpio_direction_output.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boards/pcm038/pcm038.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
index d247edc..f39660c 100644
--- a/arch/arm/boards/pcm038/pcm038.c
+++ b/arch/arm/boards/pcm038/pcm038.c
@@ -260,7 +260,6 @@ static int pcm038_devices_init(void)
 	PCCR1 |= PCCR1_PERCLK2_EN;
 
 	gpio_direction_output(GPIO_PORTD | 28, 0);
-	gpio_set_value(GPIO_PORTD | 28, 0);
 
 	spi_register_board_info(pcm038_spi_board_info, ARRAY_SIZE(pcm038_spi_board_info));
 	imx27_add_spi0(&pcm038_spi_0_data);
-- 
1.7.3.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] PCM038: Removed unnecessary call to gpio_set_value

[Sascha Hauer]

On Mon, May 14, 2012 at 10:26:33PM +0400, Alexander Shiyan wrote:
> The value already is set by calling gpio_direction_output.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Applied, thanks

Sascha

> ---
>  arch/arm/boards/pcm038/pcm038.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
> index d247edc..f39660c 100644
> --- a/arch/arm/boards/pcm038/pcm038.c
> +++ b/arch/arm/boards/pcm038/pcm038.c
> @@ -260,7 +260,6 @@ static int pcm038_devices_init(void)
>  	PCCR1 |= PCCR1_PERCLK2_EN;
>  
>  	gpio_direction_output(GPIO_PORTD | 28, 0);
> -	gpio_set_value(GPIO_PORTD | 28, 0);
>  
>  	spi_register_board_info(pcm038_spi_board_info, ARRAY_SIZE(pcm038_spi_board_info));
>  	imx27_add_spi0(&pcm038_spi_0_data);
> -- 
> 1.7.3.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox