mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] PCM970: Added support for CompactFlash
Date: Thu, 17 May 2012 12:27:50 +0200	[thread overview]
Message-ID: <20120517102750.GA30400@pengutronix.de> (raw)
In-Reply-To: <1337107674-9733-1-git-send-email-shc_work@mail.ru>

On Tue, May 15, 2012 at 10:47:54PM +0400, Alexander Shiyan wrote:
> Added support for CompactFlash cards for PCM970 development board via
> PCMCIA window. Directly we cannot use this feature, because some signals
> connects to i.MX pins which cannot be configured as GPIO. This is first
> try to make this interface works, so comments are welcome.

What do you mean with "Directly we cannot use this feature"?

> 
> Hit any key to stop autoboot:  3
> barebox@Phytec phyCORE-i.MX27:/ mkdir /d
> barebox@Phytec phyCORE-i.MX27:/ mount /dev/disk0.0 fat /d
> barebox@Phytec phyCORE-i.MX27:/ ls /d
> test.txt

It seems to work fine here?

> +
> +#define PCMCIA_PIPR		__REG(IMX_PCMCIA_CTL_BASE + 0x00)
> +#define PCMCIA_PSCR		__REG(IMX_PCMCIA_CTL_BASE + 0x04)
> +#define PCMCIA_PER		__REG(IMX_PCMCIA_CTL_BASE + 0x08)
> +#define PCMCIA_PBR(x)		__REG(IMX_PCMCIA_CTL_BASE + 0x0c + ((x) << 2))
> +#define PCMCIA_POR(x)		__REG(IMX_PCMCIA_CTL_BASE + 0x28 + ((x) << 2))
> +#define PCMCIA_POFR(x)		__REG(IMX_PCMCIA_CTL_BASE + 0x44 + ((x) << 2))
> +#define PCMCIA_PGCR		__REG(IMX_PCMCIA_CTL_BASE + 0x60)
> +#define PCMCIA_PGSR		__REG(IMX_PCMCIA_CTL_BASE + 0x64)

Please don't use __REG. We should properly define the register addresses
and use writel/readl instead. I wanted to remove __REG stuff for longer
now, but never came to it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-05-17 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 18:47 Alexander Shiyan
2012-05-17 10:27 ` Sascha Hauer [this message]
2012-05-17 11:08   ` Re[2]: " Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120517102750.GA30400@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox