mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexey Galakhov <agalakhov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] Split S3C generic and S3C24xx specific code
Date: Thu, 17 May 2012 19:52:44 +0200	[thread overview]
Message-ID: <20120517175244.GH30400@pengutronix.de> (raw)
In-Reply-To: <1337088040-24138-3-git-send-email-agalakhov@gmail.com>

On Tue, May 15, 2012 at 07:20:35PM +0600, Alexey Galakhov wrote:
> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
> ---
> diff --git a/arch/arm/boards/a9m2410/a9m2410.c b/arch/arm/boards/a9m2410/a9m2410.c
> index eaafdbd..31ed772 100644
> --- a/arch/arm/boards/a9m2410/a9m2410.c
> +++ b/arch/arm/boards/a9m2410/a9m2410.c
> @@ -51,7 +51,7 @@ static int a9m2410_mem_init(void)
>  	 * Note: On this card the second SDRAM page is not used
>  	 */
>  	s3c24xx_disable_second_sdram_bank();
> -	size = s3c24xx_get_memory_size();
> +	size = s3c_get_memory_size();

Still you convert two different functions to a common name. Once again:
Please keep s3c24xx_get_memory_size and add a s5p_get_memory_size
function for the s5p SoC.
It turned out to be useful when functions (or defines) have a spcific
SoC name in them. This way you always know in which context a function
is valid. Also it makes it possible to compile in all (in this case memory
setup) functions in a single binary.
I know that we do not follow this rule very strictly in barebox, but I
won't accept patches that change places that do it right already.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-05-17 17:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 13:20 [PATCHv3 0/7] Cleaned up version of S5PV210 code Alexey Galakhov
2012-05-15 13:20 ` [PATCH 1/7] Make S3C24xx config options available for all S3Cs Alexey Galakhov
2012-05-15 13:20 ` [PATCH 2/7] Split S3C generic and S3C24xx specific code Alexey Galakhov
2012-05-17 17:52   ` Sascha Hauer [this message]
2012-05-17 18:33     ` Alexey Galakhov
2012-05-17 19:49       ` Juergen Beisert
2012-05-18  6:49         ` Alexey Galakhov
2012-05-18  8:38           ` Sascha Hauer
2012-05-18  9:06             ` Alexey Galakhov
2012-05-18  8:35       ` Sascha Hauer
2012-05-18  9:43     ` [PATCHv4 0/7] S5PV210 support (upd.) Alexey Galakhov
2012-05-18  9:43       ` [PATCH 1/7] Make S3C24xx config options available for all S3Cs Alexey Galakhov
2012-05-18  9:43       ` [PATCHv4 2/7] Split S3C generic and S3C24xx specific code Alexey Galakhov
2012-05-18  9:43       ` [PATCH 3/7] Add support for Samsung S5P architecture (S5PV210) Alexey Galakhov
2012-05-18  9:43       ` [PATCH 4/7] S5P boot header and image generator Alexey Galakhov
2012-05-18  9:43       ` [PATCHv4 5/7] S5P lowlevel clock init Alexey Galakhov
2012-05-18  9:43       ` [PATCHv4 6/7] S5P DRAM support Alexey Galakhov
2012-05-21 20:02         ` Sascha Hauer
2012-05-22  9:17           ` Alexey Galakhov
2012-05-22 18:29             ` Sascha Hauer
2012-05-22 19:12               ` Alexey Galakhov
2012-05-18  9:43       ` [PATCHv4 7/7] Add FriendlyArm Tiny210 board (S5PV210) Alexey Galakhov
2012-05-21 20:00       ` [PATCHv4 0/7] S5PV210 support (upd.) Sascha Hauer
2012-05-22  9:18         ` Alexey Galakhov
2012-05-15 13:20 ` [PATCH 3/7] Add support for Samsung S5P architecture (S5PV210) Alexey Galakhov
2012-05-15 13:20 ` [PATCH 4/7] S5P boot header and image generator Alexey Galakhov
2012-05-15 13:20 ` [PATCH 5/7] S5P lowlevel clock init Alexey Galakhov
2012-05-15 13:20 ` [PATCH 6/7] S5P DRAM support Alexey Galakhov
2012-05-15 13:20 ` [PATCH 7/7] Add FriendlyArm Tiny210 board (S5PV210) Alexey Galakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120517175244.GH30400@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=agalakhov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox