mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Alan Ott <alan@signal11.us>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] common: Make MENU select PROCESS_ESCAPE_SEQUENCE if HUSH_SHELL is selected
Date: Tue, 22 May 2012 11:27:18 +0200	[thread overview]
Message-ID: <20120522092718.GE28084@game.jcrosoft.org> (raw)
In-Reply-To: <1337657537-15367-1-git-send-email-alan@signal11.us>

On 23:32 Mon 21 May     , Alan Ott wrote:
> print_menu_entry() in common/menu.c calls on process_escape_sequence() when
> HUSH_SHELL is selected.
> 
> Signed-off-by: Alan Ott <alan@signal11.us>
> ---
>  common/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 73d620a..7cd0666 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -342,6 +342,7 @@ config AUTO_COMPLETE
>  config MENU
>  	bool
>  	prompt "Menu Framework"
> +	select PROCESS_ESCAPE_SEQUENCE if SHELL_HUSH
>  	help
>  	   a menu framework that allow us to create list menu to simplify
>  	   barebox and make it more user-frendly
you miss the point of the code

the PROCESS_ESCAPE_SEQUENCE is optionnal and need to stay optionnal
evenif Hush is enable

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-05-22  9:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21 15:53 [PATCH] common: Make MENU depend on PROCESS_ESCAPE_SEQUENCE Alan Ott
2012-05-21 20:06 ` Sascha Hauer
2012-05-22  2:40   ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22  3:35     ` Alan Ott
2012-05-21 22:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22  2:22   ` [PATCH] common: Make HUSH_SHELL select PROCESS_ESCAPE_SEQUENCE Alan Ott
2012-05-22  3:32     ` [PATCH v2] common: Make MENU select PROCESS_ESCAPE_SEQUENCE if HUSH_SHELL is selected Alan Ott
2012-05-22  9:27       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-05-22 15:08         ` Alan Ott
2012-05-22 19:04           ` Sascha Hauer
2012-05-22  2:24   ` [PATCH] common: Make MENU depend on PROCESS_ESCAPE_SEQUENCE Alan Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522092718.GE28084@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=alan@signal11.us \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox