mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] menu: add support for disable entry
Date: Tue, 29 May 2012 12:35:07 +0200	[thread overview]
Message-ID: <20120529103507.GK2202@game.jcrosoft.org> (raw)
In-Reply-To: <20120529083506.GZ30400@pengutronix.de>

On 10:35 Tue 29 May     , Sascha Hauer wrote:
> On Sun, May 27, 2012 at 03:57:13PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  .../arm/boards/at91sam9m10g45ek/env/bin/boot_board |    2 +
> >  commands/menu.c                                    |   15 +++++-
> >  common/menu.c                                      |   44 +++++++++++++------
> >  include/menu.h                                     |    1 +
> >  4 files changed, 45 insertions(+), 17 deletions(-)
> > 
> > @@ -450,6 +458,7 @@ static const __maybe_unused char cmd_menu_help[] =
> >  "Add an entry\n"
> >  "  (-R for do no exit the menu after executing the command)\n"
> >  "  (-b for box style 1 for selected)\n"
> > +"  (-D for disabel style command is not needed)\n"
> 
> s/disabel/disable/
> 
> Better talk about comment lines instead? If I understand this patch
> correctly that's what it does.
yes and no as I get in mind to beable to change the type of the menu_entry at
runtime

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-05-29 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-27 13:57 [PATCH 1/2] menu: add support to do not display the entry number Jean-Christophe PLAGNIOL-VILLARD
2012-05-27 13:57 ` [PATCH 2/2] menu: add support for disable entry Jean-Christophe PLAGNIOL-VILLARD
2012-05-29  8:35   ` Sascha Hauer
2012-05-29 10:35     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-06-01  6:34 ` [PATCH 1/2] menu: add support to do not display the entry number Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120529103507.GK2202@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox