From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 19.mo3.mail-out.ovh.net ([178.32.98.231] helo=mo3.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SZOil-0006aJ-8i for barebox@lists.infradead.org; Tue, 29 May 2012 15:52:32 +0000 Received: from mail91.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo3.mail-out.ovh.net (Postfix) with SMTP id A4ADAFFA402 for ; Tue, 29 May 2012 17:55:38 +0200 (CEST) Date: Tue, 29 May 2012 17:52:36 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120529155236.GN2202@game.jcrosoft.org> References: <1338192756-3688-1-git-send-email-antonynpavlov@gmail.com> <1338192756-3688-5-git-send-email-antonynpavlov@gmail.com> <20120529083010.GY30400@pengutronix.de> <20120529103720.GL2202@game.jcrosoft.org> <20120529104220.GT30400@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120529104220.GT30400@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v20120528 4/5] toshiba-ac100: add USB host support To: Sascha Hauer Cc: barebox@lists.infradead.org On 12:42 Tue 29 May , Sascha Hauer wrote: > On Tue, May 29, 2012 at 12:37:20PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 10:30 Tue 29 May , Sascha Hauer wrote: > > > On Mon, May 28, 2012 at 12:12:35PM +0400, Antony Pavlov wrote: > > > > Signed-off-by: Antony Pavlov > > > > --- > > > > arch/arm/boards/toshiba-ac100/board.c | 18 ++++++++++++++++++ > > > > 1 file changed, 18 insertions(+) > > > > > > > > diff --git a/arch/arm/boards/toshiba-ac100/board.c b/arch/arm/boards/toshiba-ac100/board.c > > > > index e3a5eba..3fd720d 100644 > > > > --- a/arch/arm/boards/toshiba-ac100/board.c > > > > +++ b/arch/arm/boards/toshiba-ac100/board.c > > > > @@ -24,6 +24,8 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > +#include > > > > > > > > static int ac100_mem_init(void) > > > > { > > > > @@ -32,3 +34,19 @@ static int ac100_mem_init(void) > > > > return 0; > > > > } > > > > mem_initcall(ac100_mem_init); > > > > + > > > > +#ifdef CONFIG_USB_EHCI > > > > +static struct ehci_platform_data ehci_pdata = { > > > > + .flags = EHCI_HAS_TT, > > > > +}; > > > > +#endif > > > > + > > > > +static int ac100_devices_init(void) > > > > +{ > > > > +#ifdef CONFIG_USB_EHCI > > > > + add_generic_usb_ehci_device(-1, TEGRA_USB3_BASE, &ehci_pdata); > > > > +#endif > > > > > > Better skip the ifdefs. It won't hurt except for a few bytes of wated > > > space. > > and the -1 need to be a define > > > > > > btw I think we need to change the auto allocated dev_id to -2 so -1 one have > > the same meanning as in the kernel > > I think we still have hardcoded -1 around. I check normally no Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox