From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marek Vasut <marex@denx.de>
Cc: barebox@lists.infradead.org, wsa@pengutronix.de,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH 3/4] mtd nand: add mxs-nand driver
Date: Fri, 8 Jun 2012 17:21:52 +0200 [thread overview]
Message-ID: <20120608152152.GX30400@pengutronix.de> (raw)
In-Reply-To: <201206081706.13549.marex@denx.de>
Hi Marek,
Sorry to bother you with barebox patches, I realized after the fact
that the Cc list gets expanded with the Signed-off-bys. Anyway
congratulations for your first barebox patch ;)
On Fri, Jun 08, 2012 at 05:06:13PM +0200, Marek Vasut wrote:
> Dear Sascha Hauer,
>
> > From: Wolfram Sang <w.sang@pengutronix.de>
> >
> > Based on the U-Boot version. Changed to kernel style register layout, added
> > MX23 support (WIP!), made MMU aware and adapted to barebox.
>
> Can you split the changes so it's not such a block of code, hard to review ?
Sorry, I don't have the history of this patches.
> Possibly to "kernel style register layout" (which I believe is stupid anyway,
> using struct based access is less error prone and more clear),
That's your mileage, others may vary.
> "mx23 support"
> and "mmu awareness" (whatever that is).
Basically cache flushing/invalidating.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-06-08 15:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 21:04 [PATCH] mxs NAND support Sascha Hauer
2012-06-07 21:04 ` [PATCH 1/4] ARM mxs: Add mxs_reset_block function Sascha Hauer
2012-06-07 21:04 ` [PATCH 2/4] dma: add mxs-apbh-dma driver Sascha Hauer
2012-06-07 21:04 ` [PATCH 3/4] mtd nand: add mxs-nand driver Sascha Hauer
2012-06-08 15:06 ` Marek Vasut
2012-06-08 15:21 ` Sascha Hauer [this message]
2012-06-07 21:04 ` [PATCH 4/4] ARM mxs: add bcb command to create 'boot control block' for NAND boot Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608152152.GX30400@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marex@denx.de \
--cc=w.sang@pengutronix.de \
--cc=wsa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox