Re: [PATCH] commands: add msleep command

[Sascha Hauer <s.hauer@pengutronix.de>]

On Wed, Jun 13, 2012 at 03:07:15PM +0400, Antony Pavlov wrote:
> On 13 June 2012 14:01, Steffen Trumtrar <s.trumtrar@pengutronix.de> wrote:
> > Add a command to sleep for n milliseconds.
> >
> 
> May be will be better to upgrade sleep?
> 
> SYNOPSIS
>        sleep NUMBER
> 
> DESCRIPTION
>        Pause  for  NUMBER seconds.
>        The NUMBER may be an arbitrary floating point  number.

Then we would need code which parses this floating point number. I
assume that this code will be bigger than the code needed for an
additional command. Having both sleep and msleep seems more intuitive
also.

Sascha

> 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> >  commands/Kconfig  |    4 ++++
> >  commands/Makefile |    1 +
> >  commands/msleep.c |   40 ++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 45 insertions(+)
> >  create mode 100644 commands/msleep.c
> >
> > diff --git a/commands/Kconfig b/commands/Kconfig
> > index 52e1f17..adc0914 100644
> > --- a/commands/Kconfig
> > +++ b/commands/Kconfig
> > @@ -25,6 +25,10 @@ config CMD_SLEEP
> >        tristate
> >        prompt "sleep"
> >
> > +config CMD_MSLEEP
> > +       tristate
> > +       prompt "msleep"
> > +
> >  config CMD_SAVEENV
> >        tristate
> >        select ENV_HANDLING
> > diff --git a/commands/Makefile b/commands/Makefile
> > index 4c8a0a9..0970ba3 100644
> > --- a/commands/Makefile
> > +++ b/commands/Makefile
> > @@ -10,6 +10,7 @@ obj-$(CONFIG_CMD_MTEST)               += memtest.o
> >  obj-$(CONFIG_CMD_EDIT)         += edit.o
> >  obj-$(CONFIG_CMD_EXEC)         += exec.o
> >  obj-$(CONFIG_CMD_SLEEP)                += sleep.o
> > +obj-$(CONFIG_CMD_MSLEEP)       += msleep.o
> >  obj-$(CONFIG_CMD_RESET)                += reset.o
> >  obj-$(CONFIG_CMD_GO)           += go.o
> >  obj-$(CONFIG_NET)              += net.o
> > diff --git a/commands/msleep.c b/commands/msleep.c
> > new file mode 100644
> > index 0000000..c9fa23c
> > --- /dev/null
> > +++ b/commands/msleep.c
> > @@ -0,0 +1,40 @@
> > +/*
> > + * msleep.c - delay execution for n milliseconds
> > + *
> > + * Copyright (c) 2012 Steffen Trumtrar <s.trumtrar@pengutronix.de>, Pengutronix
> > + *
> > + * derived from commands/sleep.c
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2
> > + * as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + */
> > +
> > +#include <common.h>
> > +#include <command.h>
> > +#include <clock.h>
> > +
> > +static int do_msleep(int argc, char *argv[])
> > +{
> > +       ulong delay;
> > +
> > +       if (argc != 2)
> > +               return COMMAND_ERROR_USAGE;
> > +
> > +       delay = simple_strtoul(argv[1], NULL, 10);
> > +
> > +       mdelay(delay);
> > +
> > +       return 0;
> > +}
> > +
> > +BAREBOX_CMD_START(msleep)
> > +       .cmd            = do_msleep,
> > +       .usage          = "delay execution for n milliseconds",
> > +BAREBOX_CMD_END
> > --
> > 1.7.10
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> 
> 
> 
> -- 
> Best regards,
>   Antony Pavlov
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox