From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Enable a way to provide the reason for "being here"
Date: Wed, 20 Jun 2012 17:08:52 +0200 [thread overview]
Message-ID: <201206201708.52673.jbe@pengutronix.de> (raw)
In-Reply-To: <4FE1E3CE.8050908@pengutronix.de>
Marc Kleine-Budde wrote:
> [...]
> > +
> > +#include <common.h>
> > +#include <init.h>
> > +#include <environment.h>
> > +#include <globalvar.h>
> > +#include <reset_source.h>
> > +
> > +static const char name[] = "global.system.reset";
> > +static const char unknown_reset[] = "unknown";
> > +static const char power_on_reset[] = "POR";
> > +static const char manual_reset[] = "RST";
> > +static const char watchdog[] = "WDG";
> > +static const char wake[] = "WKE";
> > +static const char jtag[] = "JTAG";
>
> what about using an array
>
> static cost char *reset_reason_array[] = {
> [RESET_UKWN] = "unknown",
> ...
> };
The result is not the same. The strings are no longer "const". But it should
not make a difference from the point of view of a possible reader. Will
change it.
> [...]
jbe
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-06-20 15:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 14:32 [PATCH] " Juergen Beisert
2012-06-20 14:32 ` [PATCH 1/2] " Juergen Beisert
2012-06-20 14:53 ` Marc Kleine-Budde
2012-06-20 15:08 ` Juergen Beisert [this message]
2012-06-20 18:50 ` Uwe Kleine-König
2012-06-20 19:09 ` Juergen Beisert
2012-06-20 19:27 ` Uwe Kleine-König
2012-06-20 19:59 ` Juergen Beisert
2012-06-20 20:09 ` Uwe Kleine-König
2012-06-20 20:57 ` Juergen Beisert
2012-06-20 14:32 ` [PATCH 2/2] Add two architectures which can detect the reset source Juergen Beisert
2012-06-20 14:59 ` Marc Kleine-Budde
2012-06-20 15:05 ` Juergen Beisert
2012-06-20 15:09 ` Marc Kleine-Budde
2012-06-21 9:16 [PATCHv2] Enable a way to provide the reason for "being here" Juergen Beisert
2012-06-21 9:16 ` [PATCH 1/2] " Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206201708.52673.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox