mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 1/2] ARM/MXS: add new way to reset the whole SoC
Date: Thu, 21 Jun 2012 10:33:20 +0200	[thread overview]
Message-ID: <201206211033.21218.jbe@pengutronix.de> (raw)
In-Reply-To: <20120620200534.GE5642@pengutronix.de>

Hi Uwe,

Uwe Kleine-König wrote:
> On Wed, Jun 20, 2012 at 09:04:09PM +0200, Juergen Beisert wrote:
> > > Is it worth to introduce a common function
> > >
> > > 	void __noreturn sensiblename(unsigned long clkctrl_reset_offset,
> > > unsigned long unused) {
> > > 		...
> > > 	}
> > >
> > > and make the reset_cpu functions for imx23 and imx28 just call
> > > sensiblename()?
> >
> > Refer "http://www.spinics.net/lists/u-boot-v2/msg07681.html"
>
> I don't see how this answers my question. To combine both answers, put
> sensiblename into arch/arm/mach-mxs/common.c and the imx23 and the imx28
> specific call to sensiblename into imx23.c and imx28.c respectively.

What would be the advantage? You add one more indirection but almost the same 
amount of code.

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-06-21  8:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20 13:49 [PATCH] ARM/MXS: free the watchdog from acting as a system reset source on demand Juergen Beisert
2012-06-20 13:49 ` [PATCH 1/2] ARM/MXS: add new way to reset the whole SoC Juergen Beisert
2012-06-20 18:46   ` Uwe Kleine-König
2012-06-20 19:04     ` Juergen Beisert
2012-06-20 20:05       ` Uwe Kleine-König
2012-06-21  8:33         ` Juergen Beisert [this message]
2012-06-20 13:49 ` [PATCH 2/2] ARM/MXS: remove the now obsolete mxs reset routine Juergen Beisert
2012-06-21  9:12 [PATCHv2] ARM/MXS: free the watchdog from acting as a system reset source on demand Juergen Beisert
2012-06-21  9:12 ` [PATCH 1/2] ARM/MXS: add new way to reset the whole SoC Juergen Beisert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206211033.21218.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox