mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization
Date: Thu, 21 Jun 2012 20:49:31 +0200	[thread overview]
Message-ID: <20120621184931.GI28394@pengutronix.de> (raw)
In-Reply-To: <1340274307.480951624@f269.mail.ru>

On Thu, Jun 21, 2012 at 02:25:07PM +0400, Alexander Shiyan wrote:
> Hello.
> 
> Thu, 21 Jun 2012 11:41:17 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:
> > On Thu, Jun 21, 2012 at 12:05:03PM +0400, Alexander Shiyan wrote:
> > 
> > <please put the reason of this change here>
> ...
> > > @@ -274,6 +273,8 @@ static int f3s_console_init(void)
> > >  {
> > >  	mxc_iomux_v3_setup_multiple_pads(f3s_pads, ARRAY_SIZE(f3s_pads));
> > >  
> > > +	imx51_init_lowlevel(800);
> > > +
> > >  	imx51_add_uart0();
> > >  
> > >  	return 0;
> ...
> 
> This is just bringing the initialization for all mx51-based boards to the same format.
> You can just reject this patch and apply only part 1.

Ok, did that.

Thanks
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-06-21 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21  8:05 [PATCH 1/2] Setup UART-pads via iomux interface Alexander Shiyan
2012-06-21  8:05 ` [PATCH 2/2] mx51-pdk: Move lowlevel_init before UART initialization Alexander Shiyan
2012-06-21  9:41   ` Sascha Hauer
2012-06-21 10:25     ` Re[2]: " Alexander Shiyan
2012-06-21 18:49       ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120621184931.GI28394@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox