mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jan Luebbe <jlu@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Regression for the Beagle Board
Date: Sun, 24 Jun 2012 01:21:59 +0200	[thread overview]
Message-ID: <20120623232159.GA30515@pengutronix.de> (raw)

Hi,

I tried to run master on the beagle board and discovered it fails to
bring up USB EHCI. I bisected it to 08845e41fba2b16dd3050b6b910c615e1bb8e57c.

commit 08845e41fba2b16dd3050b6b910c615e1bb8e57c
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Wed May 23 12:54:24 2012 +0200

    usb ehci: Add resource sizes
    
    add_usb_ehci_device registers resources with size 0. Fix this.
    
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

diff --git a/drivers/base/resource.c b/drivers/base/resource.c
index b31c7d7..347b2f0 100644
--- a/drivers/base/resource.c
+++ b/drivers/base/resource.c
@@ -113,8 +113,10 @@ struct device_d *add_usb_ehci_device(int id, resource_size_t hccr,
 
        res = xzalloc(sizeof(struct resource) * 2);
        res[0].start = hccr;
+       res[0].size = 0x40;
        res[0].flags = IORESOURCE_MEM;
        res[1].start = hcor;
+       res[1].size = 0xc0;
        res[1].flags = IORESOURCE_MEM;
 
        return add_generic_device_res("ehci", id, res, 2, pdata);

On the beagle board we have the following resources for EHCI:
/ devinfo ehci0
resources:
num   : 0
start : 0x48064800
size  : 0x00000000
num   : 1
start : 0x48064810
size  : 0x00000000
driver: ehci

This causes conflicting regions (#define DEBUG in common/resource.c):
request_region: 0x48064810:0x000000c0 conflicts with 0x48064800:0x00000040

What would be the best way to solve this? Pass the resource sizes from the
board file along with the start addresses?

Best regards,
Jan

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2012-06-23 23:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-23 23:21 Jan Luebbe [this message]
2012-06-23 23:32 ` Jan Luebbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120623232159.GA30515@pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox