mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fs/devfs.c: disallow write and erase if a partition is read-only
Date: Mon, 25 Jun 2012 19:25:57 +0200	[thread overview]
Message-ID: <20120625172557.GI14321@pengutronix.de> (raw)
In-Reply-To: <1340625807-18113-1-git-send-email-jlu@pengutronix.de>

On Mon, Jun 25, 2012 at 02:03:27PM +0200, Jan Luebbe wrote:
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>

Applied, thanks.

Sascha

> ---
>  fs/devfs.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/devfs.c b/fs/devfs.c
> index ae48451..074bb34 100644
> --- a/fs/devfs.c
> +++ b/fs/devfs.c
> @@ -49,6 +49,9 @@ static int devfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t s
>  {
>  	struct cdev *cdev = f->inode;
>  
> +	if (cdev->flags & DEVFS_PARTITION_READONLY)
> +		return -EPERM;
> +
>  	return cdev_write(cdev, buf, size, f->pos, f->flags);
>  }
>  
> @@ -70,6 +73,9 @@ static int devfs_erase(struct device_d *_dev, FILE *f, size_t count, unsigned lo
>  {
>  	struct cdev *cdev = f->inode;
>  
> +	if (cdev->flags & DEVFS_PARTITION_READONLY)
> +		return -EPERM;
> +
>  	if (!cdev->ops->erase)
>  		return -ENOSYS;
>  
> -- 
> 1.7.10
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-06-25 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 12:03 Jan Luebbe
2012-06-25 17:25 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120625172557.GI14321@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jlu@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox