mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fs/devfs.c: disallow write and erase if a partition is read-only
@ 2012-06-25 12:03 Jan Luebbe
  2012-06-25 17:25 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Luebbe @ 2012-06-25 12:03 UTC (permalink / raw)
  To: barebox

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
 fs/devfs.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/devfs.c b/fs/devfs.c
index ae48451..074bb34 100644
--- a/fs/devfs.c
+++ b/fs/devfs.c
@@ -49,6 +49,9 @@ static int devfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t s
 {
 	struct cdev *cdev = f->inode;
 
+	if (cdev->flags & DEVFS_PARTITION_READONLY)
+		return -EPERM;
+
 	return cdev_write(cdev, buf, size, f->pos, f->flags);
 }
 
@@ -70,6 +73,9 @@ static int devfs_erase(struct device_d *_dev, FILE *f, size_t count, unsigned lo
 {
 	struct cdev *cdev = f->inode;
 
+	if (cdev->flags & DEVFS_PARTITION_READONLY)
+		return -EPERM;
+
 	if (!cdev->ops->erase)
 		return -ENOSYS;
 
-- 
1.7.10


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs/devfs.c: disallow write and erase if a partition is read-only
  2012-06-25 12:03 [PATCH] fs/devfs.c: disallow write and erase if a partition is read-only Jan Luebbe
@ 2012-06-25 17:25 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-06-25 17:25 UTC (permalink / raw)
  To: Jan Luebbe; +Cc: barebox

On Mon, Jun 25, 2012 at 02:03:27PM +0200, Jan Luebbe wrote:
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>

Applied, thanks.

Sascha

> ---
>  fs/devfs.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/devfs.c b/fs/devfs.c
> index ae48451..074bb34 100644
> --- a/fs/devfs.c
> +++ b/fs/devfs.c
> @@ -49,6 +49,9 @@ static int devfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t s
>  {
>  	struct cdev *cdev = f->inode;
>  
> +	if (cdev->flags & DEVFS_PARTITION_READONLY)
> +		return -EPERM;
> +
>  	return cdev_write(cdev, buf, size, f->pos, f->flags);
>  }
>  
> @@ -70,6 +73,9 @@ static int devfs_erase(struct device_d *_dev, FILE *f, size_t count, unsigned lo
>  {
>  	struct cdev *cdev = f->inode;
>  
> +	if (cdev->flags & DEVFS_PARTITION_READONLY)
> +		return -EPERM;
> +
>  	if (!cdev->ops->erase)
>  		return -ENOSYS;
>  
> -- 
> 1.7.10
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-25 17:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-25 12:03 [PATCH] fs/devfs.c: disallow write and erase if a partition is read-only Jan Luebbe
2012-06-25 17:25 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox