mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] commands/crc: add a trailing newline after output of checksum
Date: Wed, 27 Jun 2012 10:25:37 +0200	[thread overview]
Message-ID: <20120627082537.GE1623@pengutronix.de> (raw)
In-Reply-To: <1340784793-22100-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Wed, Jun 27, 2012 at 10:13:13AM +0200, Uwe Kleine-König wrote:
> Without this patch the next command prompt starts directly after the
> calculated check sum. While at it also fix the coding style.

Under which conditions does this happen? The newline should be appended in
do_crc()

Sascha

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  commands/crc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/commands/crc.c b/commands/crc.c
> index df22941..81aa340 100644
> --- a/commands/crc.c
> +++ b/commands/crc.c
> @@ -71,7 +71,7 @@ static int file_crc(char* filename, ulong start, ulong size, ulong *crc,
>  		*total += now;
>  	}
>  
> -	printf ("CRC32 for %s 0x%08lx ... 0x%08lx ==> 0x%08lx",
> +	printf("CRC32 for %s 0x%08lx ... 0x%08lx ==> 0x%08lx\n",
>  			filename, start, start + *total - 1, *crc);
>  
>  out_free:
> -- 
> 1.7.10
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-06-27  8:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-27  8:13 Uwe Kleine-König
2012-06-27  8:25 ` Sascha Hauer [this message]
2012-06-27  9:08   ` [PATCH] commands/crc: assert newline after output with big offsets Uwe Kleine-König
2012-07-17  8:23     ` Uwe Kleine-König
2012-07-17 18:42       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120627082537.GE1623@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=kernel@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox