From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SmJQY-0004yX-D7 for barebox@lists.infradead.org; Wed, 04 Jul 2012 06:51:07 +0000 Date: Wed, 4 Jul 2012 08:51:01 +0200 From: Sascha Hauer Message-ID: <20120704065101.GD2698@pengutronix.de> References: <1341249753-5480-1-git-send-email-steve@scheftech.com> <20120703073605.GT2698@pengutronix.de> <4FF2D611.2040207@scheftech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4FF2D611.2040207@scheftech.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] Avoid SDRAM access crash To: Steve Schefter Cc: barebox@lists.infradead.org On Tue, Jul 03, 2012 at 07:22:57AM -0400, Steve Schefter wrote: > Hi Sascha. > > >I wonder why this has never hit me. On what hardware did you see this? > > Me too. All I can say is that the timing is tight. I see crashes > at various DRAM addresses, all depending on how much was left in > cache when the tlb invalidate was done. > > I'm using the Phytec phyCORE-OMAP44xx card. > > >Does the following patch solve your problem aswell? > > It does. I see that routine contains a cache flush as well. Ok, thanks for testing. I applied my version because it flushes only the relevant parts of the cache and looks more like C ;) Sascha > > Regards, > Steve > > > > >8<---------------------------------------------------- > > > >ARM mmu: flush page tables in arm_mmu_remap_sdram() > > > >Signed-off-by: Sascha Hauer > >--- > > arch/arm/cpu/mmu.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > >diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c > >index 55b07a4..607f357 100644 > >--- a/arch/arm/cpu/mmu.c > >+++ b/arch/arm/cpu/mmu.c > >@@ -147,7 +147,7 @@ static int arm_mmu_remap_sdram(struct memory_bank *bank) > > if ((phys& (SZ_1M - 1)) || (bank->size& (SZ_1M - 1))) > > return -EINVAL; > > > >- ptes = memalign(0x400, num_ptes * sizeof(u32)); > >+ ptes = memalign(PAGE_SIZE, num_ptes * sizeof(u32)); > > > > debug("ptes: 0x%p ttb_start: 0x%08lx ttb_end: 0x%08lx\n", > > ptes, ttb_start, ttb_end); > >@@ -165,6 +165,9 @@ static int arm_mmu_remap_sdram(struct memory_bank *bank) > > pte += 256; > > } > > > >+ dma_flush_range((unsigned long)ttb, (unsigned long)ttb + 0x4000); > >+ dma_flush_range((unsigned long)ptes, num_ptes * sizeof(u32)); > >+ > > tlb_invalidate(); > > > > return 0; > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox