mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] nand_base: add ONFI flash detection
Date: Thu, 5 Jul 2012 22:32:08 +0200	[thread overview]
Message-ID: <20120705223208.24dc9bad@eb-e6520> (raw)
In-Reply-To: <20120705190240.GY30009@pengutronix.de>

Hi Sascha,

Le Thu, 5 Jul 2012 21:02:40 +0200,
Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> > -	printk(KERN_INFO "NAND device: Manufacturer ID:"
> > -	       " 0x%02x, Chip ID: 0x%02x (%s %s)\n", *maf_id, dev_id,
> > -	       nand_manuf_ids[maf_idx].name, type->name);
> > +	printk("NAND device: Manufacturer ID: 0x%02x, Chip ID: 0x%02x (%s %s),"
> > +		" page size: %d, OOB size: %d\n",
> > +		*maf_id, dev_id, nand_manuf_ids[maf_idx].name,
> > +		chip->onfi_version ? chip->onfi_params.model : type->name,
> > +		mtd->writesize, mtd->oobsize);
> 
> Do we need to output writesize and oobsize here? 'devinfo nand0' will
> give the same information.
> 
that's the way it's done in the kernel so I imported the log update.

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-07-05 20:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 10:22 [PATCH 1/3] string: add strim for ONFI code Eric Bénard
2012-07-05 10:22 ` [PATCH 2/3] nand_base: add ONFI flash detection Eric Bénard
2012-07-05 19:02   ` Sascha Hauer
2012-07-05 20:32     ` Eric Bénard [this message]
2012-07-05 10:22 ` [PATCH 3/3] nand_imx: update to support onfi & 4k flashs Eric Bénard
2012-07-09  7:30 ` [PATCH 1/3] string: add strim for ONFI code Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120705223208.24dc9bad@eb-e6520 \
    --to=eric@eukrea.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox