mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Christian Kapeller <christian.kapeller@cmotion.eu>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly.
Date: Mon, 16 Jul 2012 16:25:24 +0200	[thread overview]
Message-ID: <20120716142524.GN30009@pengutronix.de> (raw)
In-Reply-To: <1342432439-27455-2-git-send-email-christian.kapeller@cmotion.eu>

On Mon, Jul 16, 2012 at 11:53:58AM +0200, Christian Kapeller wrote:
> 
> diff --git a/arch/arm/boards/karo-tx51/tx51.c b/arch/arm/boards/karo-tx51/tx51.c
> index 096683a..d862a68 100644
> --- a/arch/arm/boards/karo-tx51/tx51.c
> +++ b/arch/arm/boards/karo-tx51/tx51.c
> @@ -205,6 +205,12 @@ static inline void tx51_fec_init(void)
>  	}
>  
>  	/*
> +	 *Turn off phy power, be cautious and wait
> +	 */
> +	gpio_set_value(TX51_FEC_PHY_PWR, 0);
> +	mdelay(20);

Does this fix the mentioned regression due to iomuxing or is this
another issue?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-07-16 14:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16  9:53 [PATCH 0/2] Misc Karo TX51 fixes Christian Kapeller
2012-07-16  9:53 ` [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly Christian Kapeller
2012-07-16 14:25   ` Sascha Hauer [this message]
2012-07-16 14:31     ` Christian Kapeller
2012-07-16  9:53 ` [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting Christian Kapeller
2012-07-16 14:31   ` Sascha Hauer
2012-07-16 14:41     ` Christian Kapeller
2012-07-16 15:16       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716142524.GN30009@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=christian.kapeller@cmotion.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox