* [PATCH 0/2] Misc Karo TX51 fixes
@ 2012-07-16 9:53 Christian Kapeller
2012-07-16 9:53 ` [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly Christian Kapeller
2012-07-16 9:53 ` [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting Christian Kapeller
0 siblings, 2 replies; 8+ messages in thread
From: Christian Kapeller @ 2012-07-16 9:53 UTC (permalink / raw)
To: barebox
The Karo TX51 port in the master tree is currently not booting. These patches
fix it by removing the 'kallsyms' config option.
Another issue fixed is unreliable resetting of the ethernet phy chip.
Christian Kapeller (2):
tx51: ensure eth phy resets properly by driving reset pin explicitly.
tx51: Disable kallsyms. It prevents the board from booting.
arch/arm/boards/karo-tx51/tx51.c | 8 +++++++-
arch/arm/configs/tx51stk5_defconfig | 1 -
2 files changed, 7 insertions(+), 2 deletions(-)
--
1.7.5.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly.
2012-07-16 9:53 [PATCH 0/2] Misc Karo TX51 fixes Christian Kapeller
@ 2012-07-16 9:53 ` Christian Kapeller
2012-07-16 14:25 ` Sascha Hauer
2012-07-16 9:53 ` [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting Christian Kapeller
1 sibling, 1 reply; 8+ messages in thread
From: Christian Kapeller @ 2012-07-16 9:53 UTC (permalink / raw)
To: barebox
diff --git a/arch/arm/boards/karo-tx51/tx51.c b/arch/arm/boards/karo-tx51/tx51.c
index 096683a..d862a68 100644
--- a/arch/arm/boards/karo-tx51/tx51.c
+++ b/arch/arm/boards/karo-tx51/tx51.c
@@ -205,6 +205,12 @@ static inline void tx51_fec_init(void)
}
/*
+ *Turn off phy power, be cautious and wait
+ */
+ gpio_set_value(TX51_FEC_PHY_PWR, 0);
+ mdelay(20);
+
+ /*
*Turn on phy power, leave in reset state
*/
gpio_set_value(TX51_FEC_PHY_PWR, 1);
@@ -212,7 +218,7 @@ static inline void tx51_fec_init(void)
/*
* Wait some time to let the phy activate the internal regulator
*/
- mdelay(10);
+ mdelay(20);
/*
* Deassert reset, phy latches the rest of bootstrap pins
--
1.7.5.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting.
2012-07-16 9:53 [PATCH 0/2] Misc Karo TX51 fixes Christian Kapeller
2012-07-16 9:53 ` [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly Christian Kapeller
@ 2012-07-16 9:53 ` Christian Kapeller
2012-07-16 14:31 ` Sascha Hauer
1 sibling, 1 reply; 8+ messages in thread
From: Christian Kapeller @ 2012-07-16 9:53 UTC (permalink / raw)
To: barebox
diff --git a/arch/arm/configs/tx51stk5_defconfig b/arch/arm/configs/tx51stk5_defconfig
index 7fff0f0..e1796b9 100644
--- a/arch/arm/configs/tx51stk5_defconfig
+++ b/arch/arm/configs/tx51stk5_defconfig
@@ -32,7 +32,6 @@ CONFIG_HAVE_CONFIGURABLE_TEXT_BASE=y
CONFIG_HAVE_CONFIGURABLE_MEMORY_LAYOUT=y
CONFIG_MEMORY_LAYOUT_DEFAULT=y
CONFIG_MALLOC_TLSF=y
-CONFIG_KALLSYMS=y
CONFIG_LONGHELP=y
CONFIG_SHELL_HUSH=y
CONFIG_GLOB=y
--
1.7.5.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly.
2012-07-16 9:53 ` [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly Christian Kapeller
@ 2012-07-16 14:25 ` Sascha Hauer
2012-07-16 14:31 ` Christian Kapeller
0 siblings, 1 reply; 8+ messages in thread
From: Sascha Hauer @ 2012-07-16 14:25 UTC (permalink / raw)
To: Christian Kapeller; +Cc: barebox
On Mon, Jul 16, 2012 at 11:53:58AM +0200, Christian Kapeller wrote:
>
> diff --git a/arch/arm/boards/karo-tx51/tx51.c b/arch/arm/boards/karo-tx51/tx51.c
> index 096683a..d862a68 100644
> --- a/arch/arm/boards/karo-tx51/tx51.c
> +++ b/arch/arm/boards/karo-tx51/tx51.c
> @@ -205,6 +205,12 @@ static inline void tx51_fec_init(void)
> }
>
> /*
> + *Turn off phy power, be cautious and wait
> + */
> + gpio_set_value(TX51_FEC_PHY_PWR, 0);
> + mdelay(20);
Does this fix the mentioned regression due to iomuxing or is this
another issue?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly.
2012-07-16 14:25 ` Sascha Hauer
@ 2012-07-16 14:31 ` Christian Kapeller
0 siblings, 0 replies; 8+ messages in thread
From: Christian Kapeller @ 2012-07-16 14:31 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 07/16/2012 04:25 PM, Sascha Hauer wrote:
> On Mon, Jul 16, 2012 at 11:53:58AM +0200, Christian Kapeller wrote:
>>
>> diff --git a/arch/arm/boards/karo-tx51/tx51.c b/arch/arm/boards/karo-tx51/tx51.c
>> index 096683a..d862a68 100644
>> --- a/arch/arm/boards/karo-tx51/tx51.c
>> +++ b/arch/arm/boards/karo-tx51/tx51.c
>> @@ -205,6 +205,12 @@ static inline void tx51_fec_init(void)
>> }
>>
>> /*
>> + *Turn off phy power, be cautious and wait
>> + */
>> + gpio_set_value(TX51_FEC_PHY_PWR, 0);
>> + mdelay(20);
>
> Does this fix the mentioned regression due to iomuxing or is this
> another issue?
Nope, that is another issue. This fix is from my v2012.03.0 branch.
Without it the phy init worked only flaky.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting.
2012-07-16 9:53 ` [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting Christian Kapeller
@ 2012-07-16 14:31 ` Sascha Hauer
2012-07-16 14:41 ` Christian Kapeller
0 siblings, 1 reply; 8+ messages in thread
From: Sascha Hauer @ 2012-07-16 14:31 UTC (permalink / raw)
To: Christian Kapeller; +Cc: barebox
On Mon, Jul 16, 2012 at 11:53:59AM +0200, Christian Kapeller wrote:
>
> diff --git a/arch/arm/configs/tx51stk5_defconfig b/arch/arm/configs/tx51stk5_defconfig
> index 7fff0f0..e1796b9 100644
> --- a/arch/arm/configs/tx51stk5_defconfig
> +++ b/arch/arm/configs/tx51stk5_defconfig
> @@ -32,7 +32,6 @@ CONFIG_HAVE_CONFIGURABLE_TEXT_BASE=y
> CONFIG_HAVE_CONFIGURABLE_MEMORY_LAYOUT=y
> CONFIG_MEMORY_LAYOUT_DEFAULT=y
> CONFIG_MALLOC_TLSF=y
> -CONFIG_KALLSYMS=y
Of course I rather would like to fix the underlying issue. Does this
happen on a second stage barebox aswell?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting.
2012-07-16 14:31 ` Sascha Hauer
@ 2012-07-16 14:41 ` Christian Kapeller
2012-07-16 15:16 ` Sascha Hauer
0 siblings, 1 reply; 8+ messages in thread
From: Christian Kapeller @ 2012-07-16 14:41 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 07/16/2012 04:31 PM, Sascha Hauer wrote:
> On Mon, Jul 16, 2012 at 11:53:59AM +0200, Christian Kapeller wrote:
>>
>> diff --git a/arch/arm/configs/tx51stk5_defconfig b/arch/arm/configs/tx51stk5_defconfig
>> index 7fff0f0..e1796b9 100644
>> --- a/arch/arm/configs/tx51stk5_defconfig
>> +++ b/arch/arm/configs/tx51stk5_defconfig
>> @@ -32,7 +32,6 @@ CONFIG_HAVE_CONFIGURABLE_TEXT_BASE=y
>> CONFIG_HAVE_CONFIGURABLE_MEMORY_LAYOUT=y
>> CONFIG_MEMORY_LAYOUT_DEFAULT=y
>> CONFIG_MALLOC_TLSF=y
>> -CONFIG_KALLSYMS=y
>
> Of course I rather would like to fix the underlying issue. Does this
> happen on a second stage barebox aswell?
I hear you. My intend was to have at least a booting board, rather than
a brick.
I just flashed tx51 barebox without CONFIG_KALLSYMS, and could
successfully start a barebox binary with CONFIG_KALLSYMS set using
bootm.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting.
2012-07-16 14:41 ` Christian Kapeller
@ 2012-07-16 15:16 ` Sascha Hauer
0 siblings, 0 replies; 8+ messages in thread
From: Sascha Hauer @ 2012-07-16 15:16 UTC (permalink / raw)
To: Christian Kapeller; +Cc: barebox
On Mon, Jul 16, 2012 at 04:41:45PM +0200, Christian Kapeller wrote:
> On 07/16/2012 04:31 PM, Sascha Hauer wrote:
> > On Mon, Jul 16, 2012 at 11:53:59AM +0200, Christian Kapeller wrote:
> >>
> >> diff --git a/arch/arm/configs/tx51stk5_defconfig b/arch/arm/configs/tx51stk5_defconfig
> >> index 7fff0f0..e1796b9 100644
> >> --- a/arch/arm/configs/tx51stk5_defconfig
> >> +++ b/arch/arm/configs/tx51stk5_defconfig
> >> @@ -32,7 +32,6 @@ CONFIG_HAVE_CONFIGURABLE_TEXT_BASE=y
> >> CONFIG_HAVE_CONFIGURABLE_MEMORY_LAYOUT=y
> >> CONFIG_MEMORY_LAYOUT_DEFAULT=y
> >> CONFIG_MALLOC_TLSF=y
> >> -CONFIG_KALLSYMS=y
> >
> > Of course I rather would like to fix the underlying issue. Does this
> > happen on a second stage barebox aswell?
>
> I hear you. My intend was to have at least a booting board, rather than
> a brick.
>
> I just flashed tx51 barebox without CONFIG_KALLSYMS, and could
> successfully start a barebox binary with CONFIG_KALLSYMS set using
> bootm.
A binary built with CONFIG_KALLSYMS is >256k and without CONFIG_KALLSYMS
it's smaller than 256k. Looking at the karo i.MX51 flash_header.c it
seems it does it right:
unsigned long __image_len_section barebox_len = DCD_BAREBOX_SIZE;
Nevertheless 256k is a typical maximum bootloader size which is assumed
in some places, I would start looking there.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-07-16 15:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-16 9:53 [PATCH 0/2] Misc Karo TX51 fixes Christian Kapeller
2012-07-16 9:53 ` [PATCH 1/2] tx51: ensure eth phy resets properly by driving reset pin explicitly Christian Kapeller
2012-07-16 14:25 ` Sascha Hauer
2012-07-16 14:31 ` Christian Kapeller
2012-07-16 9:53 ` [PATCH 2/2] tx51: Disable kallsyms. It prevents the board from booting Christian Kapeller
2012-07-16 14:31 ` Sascha Hauer
2012-07-16 14:41 ` Christian Kapeller
2012-07-16 15:16 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox