* [PATCH] Fix compile error loady command, without loadb.
@ 2012-07-19 11:40 Christian Kapeller
2012-07-19 14:36 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Christian Kapeller @ 2012-07-19 11:40 UTC (permalink / raw)
To: barebox
The global variable ofd is needed by both loady and loadb.
---
commands/loadb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/commands/loadb.c b/commands/loadb.c
index 9a697dd..50f323e 100644
--- a/commands/loadb.c
+++ b/commands/loadb.c
@@ -61,10 +61,10 @@
#define untochar(x) ((int) (((x) - SPACE) & 0xff))
#define DEF_FILE "image.bin"
-#ifdef CONFIG_CMD_LOADB
-
static int ofd; /* output file descriptor */
+#ifdef CONFIG_CMD_LOADB
+
/* Size of my buffer to write to o/p file */
#define MAX_WRITE_BUFFER 4096 /* Write size to o/p file */
static char *write_buffer; /* buffer for finalized data to write */
--
1.7.5.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix compile error loady command, without loadb.
2012-07-19 11:40 [PATCH] Fix compile error loady command, without loadb Christian Kapeller
@ 2012-07-19 14:36 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-07-19 14:36 UTC (permalink / raw)
To: Christian Kapeller; +Cc: barebox
Hi Christian,
This is already fixed in -next.
On Thu, Jul 19, 2012 at 01:40:19PM +0200, Christian Kapeller wrote:
> The global variable ofd is needed by both loady and loadb.
btw please sign-off your patches.
Sascha
> ---
> commands/loadb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/commands/loadb.c b/commands/loadb.c
> index 9a697dd..50f323e 100644
> --- a/commands/loadb.c
> +++ b/commands/loadb.c
> @@ -61,10 +61,10 @@
> #define untochar(x) ((int) (((x) - SPACE) & 0xff))
> #define DEF_FILE "image.bin"
>
> -#ifdef CONFIG_CMD_LOADB
> -
> static int ofd; /* output file descriptor */
>
> +#ifdef CONFIG_CMD_LOADB
> +
> /* Size of my buffer to write to o/p file */
> #define MAX_WRITE_BUFFER 4096 /* Write size to o/p file */
> static char *write_buffer; /* buffer for finalized data to write */
> --
> 1.7.5.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-19 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 11:40 [PATCH] Fix compile error loady command, without loadb Christian Kapeller
2012-07-19 14:36 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox