From: Johannes Stezenbach <js@sig21.net>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 9/9] Add compressed image support
Date: Fri, 20 Jul 2012 17:01:06 +0200 [thread overview]
Message-ID: <20120720150106.GA20593@sig21.net> (raw)
In-Reply-To: <20120719204212.GH30009@pengutronix.de>
On Thu, Jul 19, 2012 at 10:42:12PM +0200, Sascha Hauer wrote:
> On Thu, Jul 19, 2012 at 08:32:38PM +0200, Johannes Stezenbach wrote:
> > > > ...
> > > > LD barebox
> > > > arm-linux-ld -EL -Map barebox.map -static --gc-sections -o barebox \
> > > > -T arch/arm/lib/barebox-compressed.lds \
> > > > --start-group common/built-in.o drivers/built-in.o commands/built-in.o lib/built-in.o crypto/built-in.o net/built-in.o fs/built-in.o arch/arm/boards/foo/built-in.o arch/arm/mach-foo/built-in.o arch/arm/lib/built-in.o arch/arm/cpu/built-in.o piggy.lzo.o --end-group
> > > >
> > > >
> > > > It shouldn't link all the -built-in.o into the uncompressor, should it?
> > > > Or is it supposed to work via --gc-sections trick?
> > >
> > > Yes, it works using --gc-sections. Are you building a defconfig or a
> > > custom one? If the error above is correct start_barebox is referenced
> > > from the decompressor code. This should not happen.
> >
> > I'm building a custom one (unpublished code). It has some SPI flash
> > boot assembly code, I guess that might cause the issue wrt the new section
> > annotations. I'll look at it tomorrow. However, I still wonder
> > about the empty $(barebox-compressed)?
>
> It's empty here aswell, so this shouldn't be a problem. Though I should
> probably simpy remove it.
OK, got it to work now. I had a "b start" in my SPI flash boot code
to skip low level init when it was loaded into RAM via JTAG.
That needed to be changed to "b compressed_start". It seems
there is no real support in ld to debug this, I added --cref
to LDFLAGS_barebox but I still couldn't see why stuff from
common/built-in.o gets pulled into the uncompressor.
BTW, I briefly tried the lzo update from
http://lkml.org/lkml/2012/7/16/355
(don't have much time to do real benchmarks, just tried
"time uncompress somefile.lzo somefile"),
but it seems to be slower on ARM926 than the old version
(504ms vs 362ms).
Thanks,
Johannes
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-07-20 15:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 8:12 Compressed barebox " Sascha Hauer
2012-07-19 8:12 ` [PATCH 1/9] lzo: Allow for static inlining Sascha Hauer
2012-07-19 8:12 ` [PATCH 2/9] ARM lds: remove unused got Sascha Hauer
2012-07-19 8:12 ` [PATCH 3/9] ARM: remove board linker script option Sascha Hauer
2012-07-19 8:12 ` [PATCH 4/9] ARM: remove exception vectors from boards Sascha Hauer
2012-07-19 8:12 ` [PATCH 5/9] ARM startup: calculate offset instead of runtime address Sascha Hauer
2012-07-19 8:12 ` [PATCH 6/9] ARM ep93xx: Get rid of special handling in linker file Sascha Hauer
2012-07-19 8:13 ` [PATCH 7/9] ARM boards: Use _text rather than TEXT_BASE Sascha Hauer
2012-07-19 8:13 ` [PATCH 8/9] ARM: Separate assembler functions into their own section Sascha Hauer
2012-07-19 10:38 ` Marc Kleine-Budde
2012-07-19 14:04 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-19 14:08 ` Sascha Hauer
2012-07-19 20:45 ` Sascha Hauer
2012-07-20 16:20 ` Johannes Stezenbach
2012-07-23 20:00 ` Sascha Hauer
2012-07-23 19:59 ` Sascha Hauer
2012-07-19 8:13 ` [PATCH 9/9] Add compressed image support Sascha Hauer
2012-07-19 14:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-19 17:08 ` Johannes Stezenbach
2012-07-19 17:41 ` Sascha Hauer
2012-07-19 18:32 ` Johannes Stezenbach
2012-07-19 20:42 ` Sascha Hauer
2012-07-20 15:01 ` Johannes Stezenbach [this message]
2012-07-20 15:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-19 15:08 ` Compressed barebox " Jean-Christophe PLAGNIOL-VILLARD
2012-07-19 16:05 ` Sascha Hauer
2012-07-19 20:11 ` Robert Jarzmik
2012-07-20 7:59 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720150106.GA20593@sig21.net \
--to=js@sig21.net \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox