mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/7] compressed: rename barebox target to zbarebox and zbarebox.bin
Date: Mon, 23 Jul 2012 08:41:34 +0200	[thread overview]
Message-ID: <20120723064134.GO22657@game.jcrosoft.org> (raw)
In-Reply-To: <20120723063523.GV30009@pengutronix.de>

On 08:35 Mon 23 Jul     , Sascha Hauer wrote:
> On Mon, Jul 23, 2012 at 06:26:02AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Today we link to whole barebox and rely on gcc to cleanup via it's garbage
> > collector.
> > Now we specify only what is needed and introduce a new directory with source
> > only related to the compressed target.
> > 
> > Build it in arch/<arm>/compressed
> > Rebuild all the needed object.
> > 
> > Keep the previous target untouched.
> > This fix the modules support and allow custom flags for each file.
> > 
> > Import string functions from linux 3.4 (arch/arm/boot/compressed/string.c) and
> > implement a dummy panic.
> 
> This does not work on all targets having a lowlevel init:
> 
> arch/arm/compressed/start.o: In function `reset':
> start.c:(.text_bare_init.text+0x28): undefined reference to `board_init_lowlevel'
> 
> Why don't we simply do this:
> 
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 647c536..12869b3 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -150,11 +150,9 @@ TEXT_BASE = $(CONFIG_TEXT_BASE)
>  
>  CPPFLAGS += -DTEXT_BASE=$(TEXT_BASE)
>  
> -ifndef CONFIG_MODULES
>  # Add cleanup flags
>  CPPFLAGS += -fdata-sections -ffunction-sections
>  LDFLAGS_barebox += -static --gc-sections
> -endif
you can not do this as this break modules

for board_init_lowlevel we need to add it to the decompressor

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-07-23  6:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23  4:20 [PATCH 0/7 V2] compressed image update Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:25 ` [PATCH 1/7] stddev: make it selectable via Kconfig Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:25   ` [PATCH 2/7] decompress_unlzo: define decompress_unlzo as decompress Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:25   ` [PATCH 3/7] compressed image: factorise compressor type Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:26   ` [PATCH 4/7] decompressor: import malloc/free implementation for linux 3.4 Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:26   ` [PATCH 5/7] ARM: add early malloc support needed by the decompressor Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:26   ` [PATCH 6/7] compressed: rename barebox target to zbarebox and zbarebox.bin Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  6:35     ` Sascha Hauer
2012-07-23  6:41       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-07-23  7:16         ` Sascha Hauer
2012-07-23  8:02           ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  8:05             ` Sascha Hauer
2012-07-23  8:18               ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  8:22                 ` Sascha Hauer
2012-07-23  9:08                   ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  9:05     ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-23  4:26   ` [PATCH 7/7] compressed image: add gzip support Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120723064134.GO22657@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox