From: Sascha Hauer <s.hauer@pengutronix.de>
To: Svetlana Khafizova <sv.khafizova@gmail.com>
Cc: barebox@lists.infradead.org, Aleksey Kuleshov <rndfax@yandex.ru>
Subject: Re: [PATCH] Makefile: update barebox version if CONFIG_KALLSYMS is not set
Date: Mon, 23 Jul 2012 22:10:12 +0200 [thread overview]
Message-ID: <20120723201012.GC30009@pengutronix.de> (raw)
In-Reply-To: <1343050608-2091-1-git-send-email-sv.khafizova@gmail.com>
On Mon, Jul 23, 2012 at 05:36:48PM +0400, Svetlana Khafizova wrote:
> If CONFIG_KALLSYMS is not set then barebox version is always "#0".
> By-default on mips boards CONFIG_KALLSYMS don't set, so barebox
> version does not increase after every build.
> This patch fixes the problem.
Same here. Applied.
Thanks,
Sascha
>
> Signed-off-by: Svetlana Khafizova <sv.khafizova@gmail.com>
> Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
> Acked-by:: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index ebcf9bf..ac5eaaf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -549,12 +549,13 @@ quiet_cmd_sysmap = SYSMAP
> cmd_sysmap = $(CONFIG_SHELL) $(srctree)/scripts/mksysmap
>
> # Link of barebox
> +# If CONFIG_KALLSYMS is set .version is already updated
> # Generate System.map and verify that the content is consistent
> # Use + in front of the barebox_version rule to silent warning with make -j2
> # First command is ':' to allow us to use + in front of the rule
> define rule_barebox__
> :
> -
> + $(if $(CONFIG_KALLSYMS),,+$(call cmd,barebox_version))
> $(call cmd,barebox__)
>
> $(Q)echo 'cmd_$@ := $(cmd_barebox__)' > $(@D)/.$(@F).cmd
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-07-23 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 13:36 Svetlana Khafizova
2012-07-23 20:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723201012.GC30009@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rndfax@yandex.ru \
--cc=sv.khafizova@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox