[PATCH] Makefile: update barebox version if CONFIG_KALLSYMS is not set

[PATCH] Makefile: update barebox version if CONFIG_KALLSYMS is not set

[Svetlana Khafizova]

If CONFIG_KALLSYMS is not set then barebox version is always "#0".
By-default on mips boards CONFIG_KALLSYMS don't set, so barebox
version does not increase after every build.
This patch fixes the problem.

Signed-off-by: Svetlana Khafizova <sv.khafizova@gmail.com>
Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
Acked-by:: Antony Pavlov <antonynpavlov@gmail.com>
---
 Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index ebcf9bf..ac5eaaf 100644
--- a/Makefile
+++ b/Makefile
@@ -549,12 +549,13 @@ quiet_cmd_sysmap = SYSMAP
       cmd_sysmap = $(CONFIG_SHELL) $(srctree)/scripts/mksysmap
 
 # Link of barebox
+# If CONFIG_KALLSYMS is set .version is already updated
 # Generate System.map and verify that the content is consistent
 # Use + in front of the barebox_version rule to silent warning with make -j2
 # First command is ':' to allow us to use + in front of the rule
 define rule_barebox__
 	:
-
+	$(if $(CONFIG_KALLSYMS),,+$(call cmd,barebox_version))
 	$(call cmd,barebox__)
 
 	$(Q)echo 'cmd_$@ := $(cmd_barebox__)' > $(@D)/.$(@F).cmd
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Makefile: update barebox version if CONFIG_KALLSYMS is not set

[Sascha Hauer]

On Mon, Jul 23, 2012 at 05:36:48PM +0400, Svetlana Khafizova wrote:
> If CONFIG_KALLSYMS is not set then barebox version is always "#0".
> By-default on mips boards CONFIG_KALLSYMS don't set, so barebox
> version does not increase after every build.
> This patch fixes the problem.

Same here. Applied.

Thanks,
 Sascha

> 
> Signed-off-by: Svetlana Khafizova <sv.khafizova@gmail.com>
> Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
> Acked-by:: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index ebcf9bf..ac5eaaf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -549,12 +549,13 @@ quiet_cmd_sysmap = SYSMAP
>        cmd_sysmap = $(CONFIG_SHELL) $(srctree)/scripts/mksysmap
>  
>  # Link of barebox
> +# If CONFIG_KALLSYMS is set .version is already updated
>  # Generate System.map and verify that the content is consistent
>  # Use + in front of the barebox_version rule to silent warning with make -j2
>  # First command is ':' to allow us to use + in front of the rule
>  define rule_barebox__
>  	:
> -
> +	$(if $(CONFIG_KALLSYMS),,+$(call cmd,barebox_version))
>  	$(call cmd,barebox__)
>  
>  	$(Q)echo 'cmd_$@ := $(cmd_barebox__)' > $(@D)/.$(@F).cmd
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox