From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/7] nand: fix build error when BBT not enabled.
Date: Sun, 29 Jul 2012 11:58:16 +0200 [thread overview]
Message-ID: <20120729095816.GB26655@game.jcrosoft.org> (raw)
In-Reply-To: <1343547714-32740-6-git-send-email-marc@cpdesign.com.au>
On 17:41 Sun 29 Jul , Marc Reilly wrote:
> This fixes following error when bad blocks config option is not enabled:
>
> drivers/built-in.o: In function `nand_erase_nand':
> drivers/mtd/nand/nand_write.c:721: undefined reference to `nand_update_bbt'
> drivers/built-in.o: In function `nand_default_block_markbad':
> drivers/mtd/nand/nand_write.c:76: undefined reference to `nand_update_bbt'
> make: *** [barebox] Error 1
>
> Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
> ---
> drivers/mtd/nand/nand_write.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_write.c b/drivers/mtd/nand/nand_write.c
> index 13b6c89..0fd49d6 100644
> --- a/drivers/mtd/nand/nand_write.c
> +++ b/drivers/mtd/nand/nand_write.c
> @@ -72,9 +72,15 @@ int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
> chip->bbt[block >> 2] |= 0x01 << ((block & 0x03) << 1);
>
> /* Do we have a flash based bad block table ? */
> - if (chip->options & NAND_USE_FLASH_BBT)
> + if (chip->options & NAND_USE_FLASH_BBT) {
> +#if defined(CONFIG_NAND_BBT)
use if (IS_ENABLED())
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-07-29 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 7:41 at24 eeprom driver (V2) and misc patches Marc Reilly
2012-07-29 7:41 ` [PATCH 1/7] imx35: 6-bit divider helper Marc Reilly
2012-07-29 7:41 ` [PATCH 2/7] imx35: mmc clock has 6 bit divider, not 3_3 Marc Reilly
2012-07-29 7:41 ` [PATCH 3/7] i2c: add platform_data for i2c_board_info Marc Reilly
2012-07-30 8:13 ` Uwe Kleine-König
2012-07-30 9:41 ` Sascha Hauer
2012-07-29 7:41 ` [PATCH 4/7] i2c: device id default to -1 for auto assignment Marc Reilly
2012-07-29 9:59 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-29 7:41 ` [PATCH 5/7] nand: fix build error when BBT not enabled Marc Reilly
2012-07-29 9:58 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-07-29 11:28 ` Marc Reilly
2012-07-29 7:41 ` [PATCH 6/7] nand: Prevent drivers setting NAND_USE_FLASH_BBT if BBT config " Marc Reilly
2012-07-29 10:00 ` Jean-Christophe PLAGNIOL-VILLARD
2012-07-29 11:30 ` Marc Reilly
2012-07-29 7:41 ` [PATCH 7/7] drivers/eeprom: at24: add I2C eeprom driver for 24c01/02 Marc Reilly
2012-07-30 8:25 ` Uwe Kleine-König
2012-07-30 10:36 ` Marc Reilly
2012-08-01 7:25 ` Uwe Kleine-König
2012-07-30 9:38 ` at24 eeprom driver (V2) and misc patches Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729095816.GB26655@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox