Re: [PATCH 1/4] fs/mount: add autodetection type support

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 10:16 Mon 13 Aug     , Uwe Kleine-König wrote:
> On Mon, Aug 13, 2012 at 09:30:01AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 09:08 Mon 13 Aug     , Uwe Kleine-König wrote:
> > > Hello,
> > > 
> > > On Sun, Aug 12, 2012 at 01:49:36PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > +static const char * detect_fs(const char *filename)
> > > > +{
> > > > +	enum filetype type = file_name_detect_type(filename);
> > > > +	struct driver_d *drv;
> > > > +	struct fs_driver_d *fdrv;
> > > > +
> > > > +	if (type == filetype_unknown)
> > > > +		return NULL;
> > > > +
> > > > +	for_each_driver(drv) {
> > > > +		fdrv = drv_to_fs_driver(drv);
> > > > +
> > > > +		if (drv->bus != &fs_bus)
> > > > +			continue;
> > > > +
> > > > +		if(type == fdrv->type)
> > > > +			return drv->name;
> > > fdrv could be local to this loop only.
> > I never declare a var in a loop
> reading over
> 
> 	git log --grep=scope
> 
> in the kernel suggests that at least there it's considered good style.
> With some false hits the list includes:
> 
> 	ccece235d3737221e7a1118fdbd8474112adac84:
> 		Finally, move the definition of the local variable "i"
> 		to the innermost scope in which it's needed.
> 	22a4cca2f4c2d60c703cdc42158c907570f508e6:
> 		Reduced the scope of the loop variable in
> 		e1000e_write_itr().
> 	2c2453f3e46139b86c1e5b0fbd821823b04e4ada:
> 		Patch shortens locals scope ...
> 	74ad8fdaefe6ccb8ef1918394a9d04a036658346:
> 		Shorten scope for iobase
> 
> which all got in after v3.6-rc1.
no sorry I really do not like this

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox