mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] filetype: add command support
Date: Mon, 13 Aug 2012 23:53:52 +0200	[thread overview]
Message-ID: <20120813215352.GW1451@pengutronix.de> (raw)
In-Reply-To: <1344888183-1489-1-git-send-email-plagnioj@jcrosoft.com>

On Mon, Aug 13, 2012 at 10:03:03PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> this will allow to detect the filetype of a file and export it as filetype
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  commands/Kconfig    |    5 +++++
>  commands/Makefile   |    1 +
>  commands/filetype.c |   60 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 66 insertions(+)
>  create mode 100644 commands/filetype.c
> 
> diff --git a/commands/Kconfig b/commands/Kconfig
> index 92a8152..e9fb9f6 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -220,6 +220,11 @@ config CMD_DIRNAME
>  	  Strip last component of file name and store the result in a
>  	  environment variable
>  
> +config CMD_FILETYPE
> +	tristate
> +	depends on FILETYPE
> +	prompt "filetype"

How about a short description of the command here?

> +
> +static int do_filetype(int argc, char *argv[])
> +{
> +	int opt;
> +	enum filetype type;
> +	char* filename = NULL;
> +	int verbose = 0;
> +
> +	while ((opt = getopt(argc, argv, "vf:")) > 0) {
> +		switch (opt) {
> +		case 'f':
> +			filename = optarg;
> +			break;
> +		case 'v':
> +			verbose = 1;
> +			break;
> +		}
> +	}
> +
> +	if (!filename)
> +		return COMMAND_ERROR_USAGE;
> +
> +	type = file_name_detect_type(filename);
> +
> +	if (verbose)
> +		pr_info("%s: %s detected\n", filename,
> +			file_type_to_string(type));
> +
> +	export_env_ull("filetype" , type);

Normally we do this by passing the variable name to the command, see
readline, basename or getopt. Lets do it the same way here.

Also, we should export strings instead of numbers. The numbers are not
documented anywhere and I think we should not expose them.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-08-13 21:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 20:03 Jean-Christophe PLAGNIOL-VILLARD
2012-08-13 21:53 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120813215352.GW1451@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox