From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 8.mo1.mail-out.ovh.net ([178.33.110.239] helo=mo1.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T3nMX-00033G-Ta for barebox@lists.infradead.org; Tue, 21 Aug 2012 12:15:14 +0000 Received: from mail31.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo1.mail-out.ovh.net (Postfix) with SMTP id B8520FF8FB7 for ; Tue, 21 Aug 2012 14:22:14 +0200 (CEST) Date: Tue, 21 Aug 2012 14:15:26 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120821121526.GF6271@game.jcrosoft.org> References: <1345472428-17417-1-git-send-email-jlu@pengutronix.de> <1345472428-17417-8-git-send-email-jlu@pengutronix.de> <20120820144755.GZ6271@game.jcrosoft.org> <20120821070841.GD15318@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120821070841.GD15318@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 07/13] omap3: allow enabling clocks for UART3, MMC1 and SPI To: Jan Luebbe Cc: barebox@lists.infradead.org On 09:08 Tue 21 Aug , Jan Luebbe wrote: > On Mon, Aug 20, 2012 at 04:47:55PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 16:20 Mon 20 Aug , Jan Luebbe wrote: > > > --- a/arch/arm/mach-omap/omap3_clock.c > > > +++ b/arch/arm/mach-omap/omap3_clock.c > > > @@ -679,11 +679,26 @@ static void per_clocks_enable(void) > > > sr32(CM_REG(FCLKEN1_CORE), 13, 1, 0x1); > > > sr32(CM_REG(ICLKEN1_CORE), 13, 1, 0x1); > > > #endif > > > +#ifdef CONFIG_OMAP_CLOCK_UART3 > > > + /* Enable UART3 clocks */ > > > + sr32(CM_REG(FCLKEN_PER), 11, 1, 0x1); > > > + sr32(CM_REG(ICLKEN_PER), 11, 1, 0x1); > > > +#endif > > > #ifdef CONFIG_OMAP_CLOCK_I2C > > > /* Turn on all 3 I2C clocks */ > > > sr32(CM_REG(FCLKEN1_CORE), 15, 3, 0x7); > > > sr32(CM_REG(ICLKEN1_CORE), 15, 3, 0x7); /* I2C1,2,3 = on */ > > > #endif > > > +#ifdef CONFIG_OMAP_CLOCK_MMC1 > > no ifdef anymore > > > > please use if (IS_ENABLE()) > > Ok. I thought IS_ENABLE was only available in next. I need this stack to work > on v2012.09, so I avoided it. > > Will change it for the next version. for mainline must Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox