mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Roberto Nibali <rnibali@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 10/18] commands: add readlink support
Date: Fri, 24 Aug 2012 20:46:06 +0200	[thread overview]
Message-ID: <20120824184606.GL6271@game.jcrosoft.org> (raw)
In-Reply-To: <CAONxwYO0RAf+3S3N1pXoB7VEgEsj30FOfyTHYkLYoNXMn798oA@mail.gmail.com>

On 11:31 Fri 24 Aug     , Roberto Nibali wrote:
> Hi Jean-Christophe
> 
> Btw, congrats on such a good and lean work on the symlink implementation!
> 
> > ---
> >  commands/Kconfig    |    6 ++++
> >  commands/Makefile   |    1 +
> >  commands/readlink.c |   78 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 85 insertions(+)
> >  create mode 100644 commands/readlink.c
> >
> > diff --git a/commands/Kconfig b/commands/Kconfig
> > index 92a8152..876f2f8 100644
> > --- a/commands/Kconfig
> > +++ b/commands/Kconfig
> > @@ -220,6 +220,12 @@ config CMD_DIRNAME
> >           Strip last component of file name and store the result in a
> >           environment variable
> >
> > +config CMD_READLINK
> > +       tristate
> > +       prompt "readlink"
> > +       help
> > +         read value of a symbolic link
> > +
> 
> Just a general two cents comment: how about generally rephrasing the
> "read value of a symbolic link" to "display file status of a symbolic
> link"?
no barebox read the value and not display it

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-08-24 18:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  4:46 [PATCH 00/18] fs: add symlink and " Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50 ` [PATCH 01/18] fs: add " Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 02/18] fs: rename stat to lstat as we implement lstat Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 03/18] fs: add symlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:35     ` Sascha Hauer
2012-09-01 10:42       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 04/18] fs: implement stat Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  9:25     ` Roberto Nibali
2012-08-24 18:47       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:52     ` Sascha Hauer
2012-09-01 10:39       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 05/18] fs: open: add symlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 06/18] fs: introduce get_mounted_path to get the path where a file is mounted Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:53     ` Sascha Hauer
2012-09-01 10:37       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 07/18] ramfs: add symlink and readlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:59     ` Sascha Hauer
2012-08-29  5:21       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 08/18] nfs: add " Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 14:04     ` Sascha Hauer
2012-08-24  4:50   ` [PATCH 09/18] test: add -L support to test if it's a symbolic link Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 10/18] commands: add readlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  9:31     ` Roberto Nibali
2012-08-24 18:46       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-08-24  4:50   ` [PATCH 11/18] command: add ln support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 12/18] ls: add symlink support to -l Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 13/18] dirname: add -V option to return only path related to the mountpoint Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 14/18] recursive_action: add ACTION_FOLLOWLINKS support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 15/18] evnfs: introduce major and minor Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 14:12     ` Sascha Hauer
2012-08-29  5:23       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 16/18] envfs: add support of variable inode size Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 17/18] envfs: add support of symlink Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 18/18] defautenv: " Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:25   ` [PATCH 01/18] fs: add readlink support Sascha Hauer
2012-09-01 10:50     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120824184606.GL6271@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=rnibali@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox