Re: [PATCH 15/18] evnfs: introduce major and minor

[Sascha Hauer <s.hauer@pengutronix.de>]

On Fri, Aug 24, 2012 at 06:50:15AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> they are store in the super block at byte 16th and 17th.
> 
> set the verison at 0.1

Only this little comment makes clear that with major and minor you mean
a version. I first thought about device nodes...

> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/environment.c |    2 ++
>  include/envfs.h      |    7 ++++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/common/environment.c b/common/environment.c
> index 52ce0de..257f35f 100644
> --- a/common/environment.c
> +++ b/common/environment.c
> @@ -125,6 +125,8 @@ int envfs_save(char *filename, char *dirname)
>  
>  	super = (struct envfs_super *)buf;
>  	super->magic = ENVFS_32(ENVFS_MAGIC);
> +	super->major = ENVFS_32(ENVFS_MAJOR);
> +	super->minor = ENVFS_32(ENVFS_MINOR);

major and minor are 8bit wide but you read 32?

>  	super->size = ENVFS_32(size);
>  
>  	/* second pass: copy files to buffer */
> diff --git a/include/envfs.h b/include/envfs.h
> index ba976d6..c6df8c5 100644
> --- a/include/envfs.h
> +++ b/include/envfs.h
> @@ -5,6 +5,9 @@
>  #include <asm/byteorder.h>
>  #endif
>  
> +#define ENVFS_MAJOR		0
> +#define ENVFS_MINOR		1
> +
>  #define ENVFS_MAGIC		    0x798fba79	/* some random number */
>  #define ENVFS_INODE_MAGIC	0x67a8c78d
>  #define ENVFS_END_MAGIC		0x6a87d6cd
> @@ -29,8 +32,10 @@ struct envfs_super {
>  	uint32_t priority;
>  	uint32_t crc;			/* crc for the data */
>  	uint32_t size;			/* size of data */
> +	uint8_t major;			/* major */
> +	uint8_t minor;			/* minor */
> +	uint16_t future;		/* reserved for future use */
>  	uint32_t flags;			/* feature flags */
> -	uint32_t future;		/* reserved for future use */

Why do you move the position of the flags field in envfs_super?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox