mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands/digest: don't print checksum for non-existing files
Date: Tue, 28 Aug 2012 08:49:00 +0200	[thread overview]
Message-ID: <20120828064900.GQ26594@pengutronix.de> (raw)
In-Reply-To: <1345749671-9045-1-git-send-email-antonynpavlov@gmail.com>

On Thu, Aug 23, 2012 at 11:21:11PM +0400, Antony Pavlov wrote:
> This fixes the case:
> 
>   barebox:/ md5sum non-existing-file
>   non-existing-file: No such file or directory
>   00000000000000000000000000000000  non-existing-file     0x00000000 ... 0xffffffffffffffff
>   barebox:/
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

> ---
>  commands/digest.c |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/commands/digest.c b/commands/digest.c
> index 07cbec9..e334a40 100644
> --- a/commands/digest.c
> +++ b/commands/digest.c
> @@ -62,11 +62,13 @@ static int do_digest(char *algorithm, int argc, char *argv[])
>  
>  		if (digest_file_window(d, filename, hash, start, size) < 0)
>  			ret = 1;
> +		else {
> +			for (i = 0; i < d->length; i++)
> +				printf("%02x", hash[i]);
>  
> -		for (i = 0; i < d->length; i++)
> -			printf("%02x", hash[i]);
> -
> -		printf("  %s\t0x%08llx ... 0x%08llx\n", filename, start, start + size);
> +			printf("  %s\t0x%08llx ... 0x%08llx\n",
> +				filename, start, start + size);
> +		}
>  
>  		argv++;
>  	}
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-08-28  6:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23 19:21 Antony Pavlov
2012-08-28  6:49 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828064900.GQ26594@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox