mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] usb_hub_power_on: wait for the power to be stable
Date: Tue, 28 Aug 2012 17:30:16 +0200	[thread overview]
Message-ID: <20120828173016.35ee0219@eb-e6520> (raw)
In-Reply-To: <1346167466-10098-1-git-send-email-eric@eukrea.com>

Hi Sascha,

Le Tue, 28 Aug 2012 17:24:25 +0200,
Eric Bénard <eric@eukrea.com> a écrit :

> - the 100ms value is taken from Linux & u-boot

and in fact after a few more tests without debug enabled, it seems that
a 200 ms value would be needed to get it working reliable with several
peripherals  so please wait for v2 before applying thyis patch.

Thanks,
Eric
> - without this, I don't see peripherals connected to a hub
> connected to an i.MX35's host port.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  drivers/usb/core/usb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
> index a5075d5..ae3eb88 100644
> --- a/drivers/usb/core/usb.c
> +++ b/drivers/usb/core/usb.c
> @@ -948,7 +948,7 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
>  		usb_set_port_feature(dev, i + 1, USB_PORT_FEAT_POWER);
>  		USB_HUB_PRINTF("port %d returns %lX\n", i + 1, dev->status);
>  	}
> -	mdelay(20);
> +	mdelay(100);
>  }
>  
>  #define MAX_TRIES 5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2012-08-28 15:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28 15:24 Eric Bénard
2012-08-28 15:24 ` [PATCH 2/2] stringlist: fix division by zero Eric Bénard
2012-08-29  7:10   ` Sascha Hauer
2012-08-28 15:30 ` Eric Bénard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828173016.35ee0219@eb-e6520 \
    --to=eric@eukrea.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox