mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] usb: use ep-specific pwrgood delay
Date: Thu, 30 Aug 2012 15:59:32 +0200	[thread overview]
Message-ID: <20120830155932.7f57c80d@eb-e6520> (raw)
In-Reply-To: <20120830132631.GA20930@pengutronix.de>

Hi Steffen,

Le Thu, 30 Aug 2012 15:26:31 +0200,
Steffen Trumtrar <s.trumtrar@pengutronix.de> a écrit :
> Where does your 50ms come from? From the debug messages of the usb-tool?
from a printf of bPwrOn2PwrGood

> It has the same factor of times 2.
yes, so in the end the hub is supposed to need 100ms to enable power.

> Have you tried hardcoding mdelay(100)?
yes -> doesn't work (see previous patch I sent 2 days ago on the same
subject).

> I first thought about doing it the same way linux does it and use
> max(pwrgood, 100). But 100ms minimum wouldn't help you either.
> I don't really like the idea of just guessing a value. But if necessary,
> I'm surely willing to change this patch.

with Linux's 100ms that works fine on the same board (under Linux). So
I'll check the if the mdelay(100) in barebox is really a 100ms timing
because the problem's root may be here !

Eric

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-08-30 13:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 12:30 [PATCH 0/3] ARM i.MX6: basic USB H1 support Steffen Trumtrar
2012-08-30 12:30 ` [PATCH 1/3] ARM i.MX6: add the usbphy1 base addr Steffen Trumtrar
2012-08-30 12:30 ` [PATCH 2/3] ARM i.MX6: enable usbphy1 Steffen Trumtrar
2012-08-30 12:30 ` [PATCH 3/3] usb: use ep-specific pwrgood delay Steffen Trumtrar
2012-08-30 13:03   ` Eric Bénard
2012-08-30 13:26     ` Steffen Trumtrar
2012-08-30 13:59       ` Eric Bénard [this message]
2012-08-30 14:12         ` Steffen Trumtrar
2012-08-30 14:18           ` Eric Bénard
2012-08-31  7:33 ` [PATCH 0/3] ARM i.MX6: basic USB H1 support Sascha Hauer
2012-08-31  7:43   ` Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120830155932.7f57c80d@eb-e6520 \
    --to=eric@eukrea.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox