mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: gregory hermant <gregory.hermant@calao-systems.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC
Date: Fri, 31 Aug 2012 09:35:23 +0200	[thread overview]
Message-ID: <20120831073523.GO26594@pengutronix.de> (raw)
In-Reply-To: <503F10DE.7020500@calao-systems.com>

On Thu, Aug 30, 2012 at 09:06:06AM +0200, gregory hermant wrote:
> Hello sascha,
> It's just a typo.
> gregory

Applied now, thanks

Sascha

> 
> Sascha Hauer wrote:
> > On Tue, Aug 28, 2012 at 08:40:57AM +0200, gregory hermant wrote:
> >> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> > 
> > The commmit log is a bit sparse. It would be interesting if this is an
> > enhancement, fixes a problem, is needed on newer board revisions...
> > 
> > Sascha
> > 
> >> ---
> >>  arch/arm/boards/tny-a926x/init.c |    2 +-
> >>  arch/arm/boards/usb-a926x/init.c |    2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boards/tny-a926x/init.c b/arch/arm/boards/tny-a926x/init.c
> >> index d58132a..5538a44 100644
> >> --- a/arch/arm/boards/tny-a926x/init.c
> >> +++ b/arch/arm/boards/tny-a926x/init.c
> >> @@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
> >>  	.ncs_read_pulse		= 4,
> >>  	.nrd_pulse		= 4,
> >>  	.ncs_write_pulse	= 4,
> >> -	.nwe_pulse		= 2,
> >> +	.nwe_pulse		= 4,
> >>  
> >>  	.read_cycle		= 7,
> >>  	.write_cycle		= 7,
> >> diff --git a/arch/arm/boards/usb-a926x/init.c b/arch/arm/boards/usb-a926x/init.c
> >> index 7e63876..00a215d 100644
> >> --- a/arch/arm/boards/usb-a926x/init.c
> >> +++ b/arch/arm/boards/usb-a926x/init.c
> >> @@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
> >>  	.ncs_read_pulse		= 4,
> >>  	.nrd_pulse		= 4,
> >>  	.ncs_write_pulse	= 4,
> >> -	.nwe_pulse		= 2,
> >> +	.nwe_pulse		= 4,
> >>  
> >>  	.read_cycle		= 7,
> >>  	.write_cycle		= 7,
> >> -- 
> >> 1.5.6.3
> >>
> >>
> >>
> >> _______________________________________________
> >> barebox mailing list
> >> barebox@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/barebox
> >>
> > 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-08-31  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  6:40 gregory hermant
2012-08-29  7:12 ` Sascha Hauer
2012-08-30  7:06   ` gregory hermant
2012-08-31  7:35     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831073523.GO26594@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=gregory.hermant@calao-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox