mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 04/18] fs: implement stat
Date: Sat, 1 Sep 2012 12:39:26 +0200	[thread overview]
Message-ID: <20120901103926.GL18708@game.jcrosoft.org> (raw)
In-Reply-To: <20120827135244.GG26594@pengutronix.de>

On 15:52 Mon 27 Aug     , Sascha Hauer wrote:
> On Fri, Aug 24, 2012 at 06:50:04AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > stat() stats the file pointed to by path and fills in buf.
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  fs/fs.c      |  102 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  include/fs.h |    6 ++--
> >  2 files changed, 104 insertions(+), 4 deletions(-)
> > 
> > diff --git a/fs/fs.c b/fs/fs.c
> > index a19e1f4..9f2e82c 100644
> > --- a/fs/fs.c
> > +++ b/fs/fs.c
> > @@ -26,6 +26,7 @@
> >  #include <errno.h>
> >  #include <malloc.h>
> >  #include <linux/stat.h>
> > +#include <linux/err.h>
> >  #include <fcntl.h>
> >  #include <xfuncs.h>
> >  #include <init.h>
> > @@ -111,6 +112,60 @@ static int init_cwd(void)
> >  
> >  postcore_initcall(init_cwd);
> >  
> > +char *normalise_link(const char *pathname, const char* symlink)
> 
> like this instead: const char *symlink
> 
> > +{
> > +	const char *buf = symlink;
> > +	char *path_free, *path;
> > +	char *absolute_path;
> > +	int point = 0;
> > +	int dir = 1;
> > +	int len;
> > +
> > +	if (symlink[0] == '/')
> > +		return strdup(symlink);
> > +
> > +	path = path_free = strdup(pathname);
> > +
> > +	while (*buf == '.' || *buf == '/') {
> > +		if (*buf == '.') {
> > +			point++;
> > +		} else if (*buf == '/') {
> > +			point = 0;
> > +			dir++;
> > +		}
> > +		if (point > 2) {
> > +			buf -= 2;
> > +			break;
> > +		}
> > +		buf++;
> > +	}
> > +
> > +	if (dir) {
> 
> This is always true. Even if not, this would be covered by while (dir)
> below.
> 
> > +		while(dir) {
> > +			path = dirname(path);
> > +			dir--;
> > +		}
> > +	}
> > +
> > +	len = strlen(buf) + strlen(path) + 1;
> > +	if (buf[0] != '/')
> > +		len++;
> > +
> > +	absolute_path = calloc(sizeof(char), len);
> > +
> > +	if(!absolute_path)
> 
> if (
> 
> > +		return NULL;
> > +
> > +	strcat(absolute_path, path);
> > +	if (buf[0] != '/')
> > +		strcat(absolute_path, "/");
> > +	strcat(absolute_path, buf);
> > +
> > +	free(path_free);
> > +
> > +	return absolute_path;
> > +}
> > +
> >  char *normalise_path(const char *pathname)
> >  {
> >  	char *path = xzalloc(strlen(pathname) + strlen(cwd) + 2);
> > @@ -512,6 +567,40 @@ out:
> >  }
> >  EXPORT_SYMBOL(unlink);
> >  
> > +static char* realfile(const char *pathname, struct stat *s)
> 
> static char *realfile
> 
> > +{
> > +	char *path = normalise_path(pathname);
> > +	int ret;
> > +
> > +	ret = lstat(path, s);
> > +	if (ret)
> > +		goto out;
> > +
> > +	if (S_ISLNK(s->st_mode)) {
> > +		char tmp[PATH_MAX];
> > +		char *new_path;
> > +
> > +		ret = readlink(path, tmp, PATH_MAX);
> > +		if (ret < 0)
> > +			goto out;
> > +
> > +		new_path = normalise_link(path, tmp);
> > +		free(path);
> > +		if (!new_path)
> > +			return ERR_PTR(-ENOMEM);
> > +		path = new_path;
> > +
> > +		ret = lstat(path, s);
> > +	}
> 
> I see no code handling multiple link levels. I think this should be
> here?
yeap I did not add it so far I plan to add it in a second step if we need it
so far I'm not really sure

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-01 10:39 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  4:46 [PATCH 00/18] fs: add symlink and readlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50 ` [PATCH 01/18] fs: add " Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 02/18] fs: rename stat to lstat as we implement lstat Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 03/18] fs: add symlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:35     ` Sascha Hauer
2012-09-01 10:42       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 04/18] fs: implement stat Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  9:25     ` Roberto Nibali
2012-08-24 18:47       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:52     ` Sascha Hauer
2012-09-01 10:39       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-08-24  4:50   ` [PATCH 05/18] fs: open: add symlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 06/18] fs: introduce get_mounted_path to get the path where a file is mounted Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:53     ` Sascha Hauer
2012-09-01 10:37       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 07/18] ramfs: add symlink and readlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:59     ` Sascha Hauer
2012-08-29  5:21       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 08/18] nfs: add " Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 14:04     ` Sascha Hauer
2012-08-24  4:50   ` [PATCH 09/18] test: add -L support to test if it's a symbolic link Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 10/18] commands: add readlink support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  9:31     ` Roberto Nibali
2012-08-24 18:46       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 11/18] command: add ln support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 12/18] ls: add symlink support to -l Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 13/18] dirname: add -V option to return only path related to the mountpoint Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 14/18] recursive_action: add ACTION_FOLLOWLINKS support Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 15/18] evnfs: introduce major and minor Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 14:12     ` Sascha Hauer
2012-08-29  5:23       ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 16/18] envfs: add support of variable inode size Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 17/18] envfs: add support of symlink Jean-Christophe PLAGNIOL-VILLARD
2012-08-24  4:50   ` [PATCH 18/18] defautenv: " Jean-Christophe PLAGNIOL-VILLARD
2012-08-27 13:25   ` [PATCH 01/18] fs: add readlink support Sascha Hauer
2012-09-01 10:50     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-01 12:35 [PATCH 00/18 v2] fs: add symlink and " Jean-Christophe PLAGNIOL-VILLARD
2012-09-01 12:37 ` [PATCH 01/18] fs: add " Jean-Christophe PLAGNIOL-VILLARD
2012-09-01 12:37   ` [PATCH 04/18] fs: implement stat Jean-Christophe PLAGNIOL-VILLARD
2012-09-03  8:28     ` Sascha Hauer
2012-09-03 10:04 [PATCH 00/18 v3] fs: add symlink and readlink support Jean-Christophe PLAGNIOL-VILLARD
2012-09-03 10:08 ` [PATCH 01/18] fs: add " Jean-Christophe PLAGNIOL-VILLARD
2012-09-03 10:08   ` [PATCH 04/18] fs: implement stat Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120901103926.GL18708@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox