mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/8] drivers/net: add driver for the EMAC device found in some TI SoCs
Date: Thu, 6 Sep 2012 09:20:12 +0200	[thread overview]
Message-ID: <20120906072012.GN26594@pengutronix.de> (raw)
In-Reply-To: <20120905180320.GA4761@game.jcrosoft.org>

On Wed, Sep 05, 2012 at 08:03:20PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:52 Wed 05 Sep     , Jan Luebbe wrote:
> > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> Again NACK
> 
> drop the struct XXXX on hte reg

I also don't like it, but let's not be religious about it.
Wolfgang currently forces all people to use structs for registers.
Forcing exactly the opposite is counterproductive I think. The original
drivers uses the structs and at some point it can be useful to compare
to this driver.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-06  7:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 15:52 Prepare support for TI AM35xx Jan Luebbe
2012-09-05 15:52 ` [PATCH 1/8] drivers/nor/m25p80: add JEDEC ID for Micron/Numonyx SPI NOR flash Jan Luebbe
2012-09-05 15:52 ` [PATCH 2/8] Makefile: add target to produce a SPL compatible uimage Jan Luebbe
2012-09-05 18:05   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-05 19:10     ` Jan Luebbe
2012-09-05 20:19       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-05 15:52 ` [PATCH 3/8] scripts: add tool to create image for SPI boot on AM35xx Jan Luebbe
2012-09-05 15:52 ` [PATCH 4/8] common: split out meminfo output and make it optional Jan Luebbe
2012-09-05 15:52 ` [PATCH 5/8] drivers/net/ksz8864rmn: add driver for Micrel KSZ8864RMN Ethernet Switch Jan Luebbe
2012-09-05 15:52 ` [PATCH 6/8] drivers/net: add driver for the EMAC device found in some TI SoCs Jan Luebbe
2012-09-05 18:03   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  7:20     ` Sascha Hauer [this message]
2012-09-06  8:58       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-05 15:52 ` [PATCH 7/8] omap3: remove unused coded for clock configuration Jan Luebbe
2012-09-05 15:52 ` [PATCH 8/8] drivers/spi: add driver for the Multichannel SPI controller found in TI SoCs Jan Luebbe
2012-09-05 18:04   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120906072012.GN26594@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox