From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 18.mo3.mail-out.ovh.net ([87.98.172.162] helo=mo3.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9Xun-0007Sc-58 for barebox@lists.infradead.org; Thu, 06 Sep 2012 08:58:22 +0000 Received: from mail91.ha.ovh.net (b7.ovh.net [213.186.33.57]) by mo3.mail-out.ovh.net (Postfix) with SMTP id A3595FF8823 for ; Thu, 6 Sep 2012 11:05:57 +0200 (CEST) Date: Thu, 6 Sep 2012 10:58:38 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20120906085838.GB20330@game.jcrosoft.org> References: <1346860337-777-1-git-send-email-jlu@pengutronix.de> <1346860337-777-7-git-send-email-jlu@pengutronix.de> <20120905180320.GA4761@game.jcrosoft.org> <20120906072012.GN26594@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120906072012.GN26594@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 6/8] drivers/net: add driver for the EMAC device found in some TI SoCs To: Sascha Hauer Cc: barebox@lists.infradead.org On 09:20 Thu 06 Sep , Sascha Hauer wrote: > On Wed, Sep 05, 2012 at 08:03:20PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 17:52 Wed 05 Sep , Jan Luebbe wrote: > > > Signed-off-by: Jan Luebbe > > Again NACK > > > > drop the struct XXXX on hte reg > > I also don't like it, but let's not be religious about it. > Wolfgang currently forces all people to use structs for registers. > Forcing exactly the opposite is counterproductive I think. The original > drivers uses the structs and at some point it can be useful to compare > to this driver. this is really a shit to read the code is horible So at the point we need to sync with the kernel I'm working on the amba pl180 driver currently if I use the u-boot one my board boot in 11s (just U-Boot), I re-write basing on linux I'm booting in arround 2s. So I do not see the point to share the driver with u-boot, I prefer to have a well writted one and optimised Best Regards, J. > > Sascha > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox